From 051ce9e2086f8cfc3c10a3d0fd5a5664bdd35fb5 Mon Sep 17 00:00:00 2001
From: hiiwave <hiiwave@gmail.com>
Date: Mon, 3 Feb 2020 19:33:38 +0800
Subject: [PATCH] Fix #3397 (#3398)

* WIP: Fix #3397

* fixup! WIP: Fix #3397

* fix: catch potential URIError threw from decodeURI
---
 browser/components/MarkdownPreview.js | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/browser/components/MarkdownPreview.js b/browser/components/MarkdownPreview.js
index ff88540f..fc5aa95c 100755
--- a/browser/components/MarkdownPreview.js
+++ b/browser/components/MarkdownPreview.js
@@ -1135,7 +1135,17 @@ export default class MarkdownPreview extends React.Component {
     }
 
     // other case
-    shell.openExternal(href)
+    this.openExternal(href)
+  }
+
+  openExternal (href) {
+    try {
+      const success = shell.openExternal(href) || shell.openExternal(decodeURI(href))
+      if (!success) console.error('failed to open url ' + href)
+    } catch (e) {
+      // URI Error threw from decodeURI
+      console.error(e)
+    }
   }
 
   render () {