From 297c764fe1844cba66e0c03c40602fd41264ca11 Mon Sep 17 00:00:00 2001 From: Baptiste Augrain Date: Sat, 15 Sep 2018 18:33:02 +0200 Subject: [PATCH] - avoid logging to console, the error when the diagram syntax is bad - fix line numbering of code blocks --- browser/components/MarkdownPreview.js | 3 --- browser/components/render/MermaidRender.js | 1 - browser/lib/markdown-it-fence.js | 2 +- 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/browser/components/MarkdownPreview.js b/browser/components/MarkdownPreview.js index 493b1fc4..42c649f9 100755 --- a/browser/components/MarkdownPreview.js +++ b/browser/components/MarkdownPreview.js @@ -704,7 +704,6 @@ export default class MarkdownPreview extends React.Component { el.addEventListener('click', this.linkClickHandler) }) } catch (e) { - console.error(e) el.className = 'flowchart-error' el.innerHTML = 'Flowchart parse error: ' + e.message } @@ -725,7 +724,6 @@ export default class MarkdownPreview extends React.Component { el.addEventListener('click', this.linkClickHandler) }) } catch (e) { - console.error(e) el.className = 'sequence-error' el.innerHTML = 'Sequence diagram parse error: ' + e.message } @@ -750,7 +748,6 @@ export default class MarkdownPreview extends React.Component { const chart = new Chart(canvas, chartConfig) } catch (e) { - console.error(e) el.className = 'chart-error' el.innerHTML = 'chartjs diagram parse error: ' + e.message } diff --git a/browser/components/render/MermaidRender.js b/browser/components/render/MermaidRender.js index f04d8cd0..0ea1960d 100644 --- a/browser/components/render/MermaidRender.js +++ b/browser/components/render/MermaidRender.js @@ -35,7 +35,6 @@ function render (element, content, theme) { element.innerHTML = svgGraph }) } catch (e) { - console.error(e) element.className = 'mermaid-error' element.innerHTML = 'mermaid diagram parse error: ' + e.message } diff --git a/browser/lib/markdown-it-fence.js b/browser/lib/markdown-it-fence.js index c2a77a72..983dc45c 100644 --- a/browser/lib/markdown-it-fence.js +++ b/browser/lib/markdown-it-fence.js @@ -64,7 +64,7 @@ module.exports = function (md, renderers, defaultRenderer) { const parameters = {} let langType = '' let fileName = '' - let firstLineNumber = 0 + let firstLineNumber = 1 let match = /^(\w[-\w]*)?(?:\(((?:\s*\w[-\w]*(?:=(?:'(?:.*?[^\\])?'|"(?:.*?[^\\])?"|(?:[^'"][^\s]*)))?)*)\))?(?::([^:]*)(?::(\d+))?)?\s*$/.exec(params) if (match) {