From f7cdafb0878c66414ecb5024d85a760cfe7826af Mon Sep 17 00:00:00 2001 From: Jannick Hemelhof Date: Mon, 9 Oct 2017 10:45:09 +0200 Subject: [PATCH 1/2] Add try/catch logic to recording of analytics events --- browser/main/lib/AwsMobileAnalyticsConfig.js | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/browser/main/lib/AwsMobileAnalyticsConfig.js b/browser/main/lib/AwsMobileAnalyticsConfig.js index 70df7b7d..734a1c40 100644 --- a/browser/main/lib/AwsMobileAnalyticsConfig.js +++ b/browser/main/lib/AwsMobileAnalyticsConfig.js @@ -26,14 +26,22 @@ function initAwsMobileAnalytics () { function recordDynamicCustomEvent (type) { if (process.env.NODE_ENV !== 'production' || !ConfigManager.default.get().amaEnabled) return - mobileAnalyticsClient.recordEvent(type) + try { + mobileAnalyticsClient.recordEvent(type) + } catch (analyticsError) { + console.error(analyticsError) + } } function recordStaticCustomEvent () { if (process.env.NODE_ENV !== 'production' || !ConfigManager.default.get().amaEnabled) return - mobileAnalyticsClient.recordEvent('UI_COLOR_THEME', { - uiColorTheme: ConfigManager.default.get().ui.theme - }) + try { + mobileAnalyticsClient.recordEvent('UI_COLOR_THEME', { + uiColorTheme: ConfigManager.default.get().ui.theme + }) + } catch (analyticsError) { + console.error(analyticsError) + } } module.exports = { From 53d3f51c74b29966237f23aba4fbbfab2d0991de Mon Sep 17 00:00:00 2001 From: Jannick Hemelhof Date: Mon, 9 Oct 2017 14:04:02 +0200 Subject: [PATCH 2/2] Cleaner catch --- browser/main/lib/AwsMobileAnalyticsConfig.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/browser/main/lib/AwsMobileAnalyticsConfig.js b/browser/main/lib/AwsMobileAnalyticsConfig.js index 734a1c40..27e51530 100644 --- a/browser/main/lib/AwsMobileAnalyticsConfig.js +++ b/browser/main/lib/AwsMobileAnalyticsConfig.js @@ -29,7 +29,9 @@ function recordDynamicCustomEvent (type) { try { mobileAnalyticsClient.recordEvent(type) } catch (analyticsError) { - console.error(analyticsError) + if (analyticsError instanceof ReferenceError) { + console.log(analyticsError.name + ': ' + analyticsError.message) + } } } @@ -40,7 +42,9 @@ function recordStaticCustomEvent () { uiColorTheme: ConfigManager.default.get().ui.theme }) } catch (analyticsError) { - console.error(analyticsError) + if (analyticsError instanceof ReferenceError) { + console.log(analyticsError.name + ': ' + analyticsError.message) + } } }