show delete confirmation dialog

browser/main/Detail/MarkdownNoteDetail.js

@@ -176,6 +176,7 @@ class MarkdownNoteDetail extends React.Component {
   handleTrashButtonClick (e) {
     const { note } = this.state
     const { isTrashed } = note
+    const { config } = this.props
 
     if (isTrashed) {
       const dialogueButtonIndex = dialog.showMessageBox(remote.getCurrentWindow(), {
@@ -199,6 +200,15 @@ class MarkdownNoteDetail extends React.Component {
           ee.once('list:moved', dispatchHandler)
         })
     } else {
+      if (config.ui.confirmDeletion) {
+        const dialogueButtonIndex = dialog.showMessageBox(remote.getCurrentWindow(), {
+          type: 'warning',
+          message: 'Confirm note deletion',
+          detail: 'Are you sure you want to move the note to the trash?',
+          buttons: ['Confirm', 'Cancel']
+        })
+        if (dialogueButtonIndex === 1) return
+      }
       note.isTrashed = true
 
       this.setState({

browser/main/Detail/SnippetNoteDetail.js

@@ -175,6 +175,7 @@ class SnippetNoteDetail extends React.Component {
   handleTrashButtonClick (e) {
     const { note } = this.state
     const { isTrashed } = note
+    const { config } = this.props
 
     if (isTrashed) {
       const dialogueButtonIndex = dialog.showMessageBox(remote.getCurrentWindow(), {
@@ -198,6 +199,16 @@ class SnippetNoteDetail extends React.Component {
           ee.once('list:moved', dispatchHandler)
         })
     } else {
+      if (config.ui.confirmDeletion) {
+        const dialogueButtonIndex = dialog.showMessageBox(remote.getCurrentWindow(), {
+          type: 'warning',
+          message: 'Confirm note deletion',
+          detail: 'Are you sure you want to move the note to the trash?',
+          buttons: ['Confirm', 'Cancel']
+        })
+        if (dialogueButtonIndex === 1) return
+      }
+
       note.isTrashed = true
 
       this.setState({

browser/main/modals/PreferencesModal/UiTab.js

@@ -62,6 +62,7 @@ class UiTab extends React.Component {
       ui: {
         theme: this.refs.uiTheme.value,
         showCopyNotification: this.refs.showCopyNotification.checked,
+        confirmDeletion: this.refs.confirmDeletion.checked,
         disableDirectWrite: this.refs.uiD2w != null
           ? this.refs.uiD2w.checked
           : false
@@ -161,6 +162,16 @@ class UiTab extends React.Component {
               Show "Saved to Clipboard" notification when copying
             </label>
           </div>
+          <div styleName='group-checkBoxSection'>
+            <label>
+              <input onChange={(e) => this.handleUIChange(e)}
+                checked={this.state.config.ui.confirmDeletion}
+                ref='confirmDeletion'
+                type='checkbox'
+              />&nbsp;
+              Show a confirmation dialog when deleting notes
+            </label>
+          </div>
           {
             global.process.platform === 'win32'
             ? <div styleName='group-checkBoxSection'>
@@ -170,7 +181,7 @@ class UiTab extends React.Component {
                   refs='uiD2w'
                   disabled={OSX}
                   type='checkbox'
-                />
+                />&nbsp;
                 Disable Direct Write(It will be applied after restarting)
               </label>
             </div>