From 8b82c448af970ddfab4fc22baf80e9ce16e68ffc Mon Sep 17 00:00:00 2001 From: tool root Date: Sat, 25 May 2019 07:58:43 +0900 Subject: [PATCH 1/3] Fix: Changed the function name --- browser/components/CodeEditor.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/browser/components/CodeEditor.js b/browser/components/CodeEditor.js index 99695cdb..f4e1da65 100644 --- a/browser/components/CodeEditor.js +++ b/browser/components/CodeEditor.js @@ -86,7 +86,7 @@ export default class CodeEditor extends React.Component { this.searchHandler = (e, msg) => this.handleSearch(msg) this.searchState = null this.scrollToLineHandeler = this.scrollToLine.bind(this) - this.setCodeEditorLintConfig = this.setCodeEditorLintConfig.bind(this) + this.setCodeEditorLintConfig = this.getCodeEditorLintConfig.bind(this) this.validatorOfMarkdown = this.validatorOfMarkdown.bind(this) this.formatTable = () => this.handleFormatTable() @@ -277,7 +277,7 @@ export default class CodeEditor extends React.Component { inputStyle: 'textarea', dragDrop: false, foldGutter: true, - lint: this.setCodeEditorLintConfig(), + lint: this.getCodeEditorLintConfig(), gutters: ['CodeMirror-linenumbers', 'CodeMirror-foldgutter', 'CodeMirror-lint-markers'], autoCloseBrackets: { pairs: this.props.matchingPairs, @@ -534,7 +534,7 @@ export default class CodeEditor extends React.Component { needRefresh = true } if (prevProps.customMarkdownLintConfig !== customMarkdownLintConfig) { - this.editor.setOption('lint', this.setCodeEditorLintConfig()) + this.editor.setOption('lint', this.getCodeEditorLintConfig()) needRefresh = true } @@ -618,7 +618,7 @@ export default class CodeEditor extends React.Component { } } - setCodeEditorLintConfig () { + getCodeEditorLintConfig () { const { mode } = this.props const checkMarkdownNoteIsOpen = mode === 'Boost Flavored Markdown' From 3b473a5f7a66178cfae1511f0a0ef3fbac46c213 Mon Sep 17 00:00:00 2001 From: tool root Date: Sat, 25 May 2019 08:04:40 +0900 Subject: [PATCH 2/3] Fix: Changed the function name --- browser/components/CodeEditor.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/browser/components/CodeEditor.js b/browser/components/CodeEditor.js index f4e1da65..20de5d41 100644 --- a/browser/components/CodeEditor.js +++ b/browser/components/CodeEditor.js @@ -86,7 +86,7 @@ export default class CodeEditor extends React.Component { this.searchHandler = (e, msg) => this.handleSearch(msg) this.searchState = null this.scrollToLineHandeler = this.scrollToLine.bind(this) - this.setCodeEditorLintConfig = this.getCodeEditorLintConfig.bind(this) + this.getCodeEditorLintConfig = this.getCodeEditorLintConfig.bind(this) this.validatorOfMarkdown = this.validatorOfMarkdown.bind(this) this.formatTable = () => this.handleFormatTable() From 2cffb50884e3b131ed85b9b1f7806aa3116b2ae3 Mon Sep 17 00:00:00 2001 From: tool root Date: Sat, 25 May 2019 08:16:25 +0900 Subject: [PATCH 3/3] Fix: Changed height of form --- browser/main/modals/PreferencesModal/UiTab.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/browser/main/modals/PreferencesModal/UiTab.js b/browser/main/modals/PreferencesModal/UiTab.js index 1f914209..0601dc23 100644 --- a/browser/main/modals/PreferencesModal/UiTab.js +++ b/browser/main/modals/PreferencesModal/UiTab.js @@ -32,7 +32,7 @@ class UiTab extends React.Component { CodeMirror.autoLoadMode(this.customCSSCM.getCodeMirror(), 'css') CodeMirror.autoLoadMode(this.customMarkdownLintConfigCM.getCodeMirror(), 'javascript') this.customCSSCM.getCodeMirror().setSize('400px', '400px') - this.customMarkdownLintConfigCM.getCodeMirror().setSize('400px', '400px') + this.customMarkdownLintConfigCM.getCodeMirror().setSize('400px', '200px') this.handleSettingDone = () => { this.setState({UiAlert: { type: 'success', @@ -648,7 +648,7 @@ class UiTab extends React.Component {
this.handleUIChange(e)} ref={e => (this.customMarkdownLintConfigCM = e)} value={config.editor.customMarkdownLintConfig}