From 47b0086bf8e840d4c89211dfe0c88ff300d4c13c Mon Sep 17 00:00:00 2001 From: Mika Andrianarijaona Date: Sat, 11 Aug 2018 11:36:36 +0200 Subject: [PATCH] Add per-folder sort - save sort configuration in `config.[folderKey].sortBy` - use lodash ` _.get(config, [folderKey, 'sortBy'])` to avoid error --- browser/main/NoteList/index.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/browser/main/NoteList/index.js b/browser/main/NoteList/index.js index eeb16a5f..23e3fb77 100644 --- a/browser/main/NoteList/index.js +++ b/browser/main/NoteList/index.js @@ -418,10 +418,10 @@ class NoteList extends React.Component { } handleSortByChange (e) { - const { dispatch } = this.props + const { dispatch, params: { folderKey } } = this.props const config = { - sortBy: e.target.value + [folderKey]: { sortBy: e.target.value } } ConfigManager.set(config) @@ -909,12 +909,12 @@ class NoteList extends React.Component { } render () { - const { location, config } = this.props + const { location, config, params: { folderKey } } = this.props let { notes } = this.props const { selectedNoteKeys } = this.state - const sortFunc = config.sortBy === 'CREATED_AT' + const sortFunc = _.get(config, [folderKey, 'sortBy']) === 'CREATED_AT' ? sortByCreatedAt - : config.sortBy === 'ALPHABETICAL' + : _.get(config, [folderKey, 'sortBy']) === 'ALPHABETICAL' ? sortByAlphabetical : sortByUpdatedAt const sortedNotes = location.pathname.match(/\/starred|\/trash/) @@ -965,7 +965,7 @@ class NoteList extends React.Component { notes.length === 1 || (autoSelectFirst && index === 0) const dateDisplay = moment( - config.sortBy === 'CREATED_AT' + _.get(config, [folderKey, 'sortBy']) === 'CREATED_AT' ? note.createdAt : note.updatedAt ).fromNow('D') @@ -1014,7 +1014,7 @@ class NoteList extends React.Component {