From 50ad5e37911b1c166a6d38bd68fc1c4b2212a4a8 Mon Sep 17 00:00:00 2001 From: Leo Lam Date: Wed, 3 May 2017 01:04:50 -0400 Subject: [PATCH] minor improvement on multi-key detection -check if number of keys pressed is the same as number of keys in a shortcut key combo before matching to avoid incorrect detection --- browser/components/MarkdownEditor.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/browser/components/MarkdownEditor.js b/browser/components/MarkdownEditor.js index 43d1a10d..4f5ab814 100644 --- a/browser/components/MarkdownEditor.js +++ b/browser/components/MarkdownEditor.js @@ -167,10 +167,13 @@ class MarkdownEditor extends React.Component { keyPressed.add(e.keyCode) this.setState({ keyPressed }) let isNoteHandlerKey = (el) => { return keyPressed.has(el) } - if (!this.state.isLocked && this.state.status === 'CODE' && this.escapeFromEditor.every(isNoteHandlerKey)) { + if (keyPressed.size === this.escapeFromEditor.length + && !this.state.isLocked + && this.state.status === 'CODE' + && this.escapeFromEditor.every(isNoteHandlerKey)) { document.activeElement.blur() } - if (this.supportMdSelectionBold.every(isNoteHandlerKey)) { + if (keyPressed.size === this.supportMdSelectionBold.length && this.supportMdSelectionBold.every(isNoteHandlerKey)) { this.addMdAroundWord('**') } }