From 5d46adf8fd0fa620cd6a44e7bbe046e414e15880 Mon Sep 17 00:00:00 2001 From: Maurits Lourens Date: Wed, 13 Dec 2017 17:11:43 +0100 Subject: [PATCH] fixed review comments --- browser/main/SideNav/StorageItem.js | 4 ++-- browser/main/lib/dataApi/exportFolder.js | 13 ++++++------- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/browser/main/SideNav/StorageItem.js b/browser/main/SideNav/StorageItem.js index 62591598..2bcbe050 100644 --- a/browser/main/SideNav/StorageItem.js +++ b/browser/main/SideNav/StorageItem.js @@ -10,7 +10,7 @@ import dataApi from 'browser/main/lib/dataApi' import StorageItemChild from 'browser/components/StorageItem' import eventEmitter from 'browser/main/lib/eventEmitter' import _ from 'lodash' -const path = require('path') +import * as path from 'path' const { remote } = require('electron') const { Menu, MenuItem, dialog } = remote @@ -25,7 +25,7 @@ class StorageItem extends React.Component { } handleHeaderContextMenu (e) { - let menu = Menu.buildFromTemplate([ + const menu = Menu.buildFromTemplate([ { label: 'Add Folder', click: (e) => this.handleAddFolderButtonClick(e) diff --git a/browser/main/lib/dataApi/exportFolder.js b/browser/main/lib/dataApi/exportFolder.js index dead4880..75dba959 100644 --- a/browser/main/lib/dataApi/exportFolder.js +++ b/browser/main/lib/dataApi/exportFolder.js @@ -1,8 +1,8 @@ -const { findStorage } = require('browser/lib/findStorage') -const resolveStorageData = require('./resolveStorageData') -const resolveStorageNotes = require('./resolveStorageNotes') -const path = require('path') -const fs = require('fs') +import { findStorage } from 'browser/lib/findStorage' +import resolveStorageData from './resolveStorageData' +import resolveStorageNotes from './resolveStorageNotes' +import * as path from 'path' +import * as fs from 'fs' /** * @param {String} storageKey @@ -46,8 +46,7 @@ function exportFolder (storageKey, folderKey, fileType, exportDir) { .filter(note => note.folder === folderKey && note.isTrashed === false && note.type === 'MARKDOWN_NOTE') .forEach(snippet => { const notePath = path.join(exportDir, `${snippet.title}.${fileType}`) - console.log(notePath) - fs.writeFile(notePath, snippet.content, (err) => { + fs.writeFileSync(notePath, snippet.content, (err) => { if (err) throw err }) })