From 7c9d3904b31e841e8ff4bc5e9b932fff33ed7286 Mon Sep 17 00:00:00 2001 From: Sosuke Suzuki Date: Wed, 10 May 2017 23:10:25 +0900 Subject: [PATCH] change to forEach from for --- browser/main/Detail/MarkdownNoteDetail.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/browser/main/Detail/MarkdownNoteDetail.js b/browser/main/Detail/MarkdownNoteDetail.js index bec7a918..1ccbd117 100644 --- a/browser/main/Detail/MarkdownNoteDetail.js +++ b/browser/main/Detail/MarkdownNoteDetail.js @@ -96,20 +96,20 @@ class MarkdownNoteDetail extends React.Component { return title } - getPercentageOfCompleteTodo (value) { - let splitted = value.split('\n') + getPercentageOfCompleteTodo (noteContent) { + let splitted = noteContent.split('\n') let numberOfTodo = 0 let numberOfCompletedTodo = 0 - for (let i = 0; i < splitted.length; i++) { - let trimmedLine = splitted[i].trim() + splitted.forEach((line) => { + let trimmedLine = line.trim() if (trimmedLine.match(/^[\+\-\*] \[\s|x\] ./)) { numberOfTodo++ } if (trimmedLine.match(/^[\+\-\*] \[x\] ./)) { numberOfCompletedTodo++ } - } + }) return Math.floor(numberOfCompletedTodo / numberOfTodo * 100) }