From 88e8d2e009420494d710b80b82a7141d15bec681 Mon Sep 17 00:00:00 2001 From: Nguyen Viet Hung Date: Fri, 28 Feb 2020 15:53:27 +1300 Subject: [PATCH] updated PR template (#3498) * updated PR template * fixed grammar --- PULL_REQUEST_TEMPLATE.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/PULL_REQUEST_TEMPLATE.md b/PULL_REQUEST_TEMPLATE.md index 58df576a..6272e9f1 100644 --- a/PULL_REQUEST_TEMPLATE.md +++ b/PULL_REQUEST_TEMPLATE.md @@ -3,13 +3,16 @@ Before submitting this PR, please make sure that: - You have read and understand the contributing.md - You have checked docs/code_style.md for information on code style --> + ## Description + ## Issue fixed + @@ -20,6 +23,7 @@ your PR will be reviewed faster if we know exactly what it does. Change :white_circle: to :radio_button: in all the options that apply --> + ## Type of changes - :white_circle: Bug fix (Change that fixed an issue) @@ -34,3 +38,5 @@ Change :white_circle: to :radio_button: in all the options that apply - :white_circle: I have written test for my code and it has been tested - :white_circle: All existing tests have been passed - :white_circle: I have attached a screenshot/video to visualize my change if possible +- :white_circle: This PR will modify the UI or affects the UX +- :white_circle: This PR will add/update/delete a keybinding