From aa0ad3bb70b5f8663b9455859b7a2f89a0d7d1bc Mon Sep 17 00:00:00 2001 From: asmsuechan Date: Sat, 18 Feb 2017 12:18:55 +0900 Subject: [PATCH] Fix from review --- browser/main/Detail/MarkdownNoteDetail.js | 26 +++++++++++------------ 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/browser/main/Detail/MarkdownNoteDetail.js b/browser/main/Detail/MarkdownNoteDetail.js index 89146acd..8b5a15ed 100644 --- a/browser/main/Detail/MarkdownNoteDetail.js +++ b/browser/main/Detail/MarkdownNoteDetail.js @@ -31,7 +31,7 @@ class MarkdownNoteDetail extends React.Component { } this.dispatchTimer = null - this.showLockButton = () => this.handleShowLockButton() + this.showLockButton = this.handleShowLockButton.bind(this) } focus () { @@ -218,7 +218,7 @@ class MarkdownNoteDetail extends React.Component { this.setState({ isLocked: !this.state.isLocked }) } - toggleLockButton () { + getToggleLockButton () { return this.state.isLocked ? 'fa-lock' : 'fa-unlock-alt' } @@ -266,17 +266,17 @@ class MarkdownNoteDetail extends React.Component {
{(() => { - let faClassName=`fa ${this.toggleLockButton()}` - if (this.state.editorStatus === 'CODE') { - return( - - ) - } + const faClassName=`fa ${this.getToggleLockButton()}` + const lockButtonComponent = + + return ( + this.state.editorStatus === 'CODE' ? lockButtonComponent : '' + ) })()}