1
0
mirror of https://github.com/BoostIo/Boostnote synced 2025-12-13 01:36:22 +00:00

Merge pull request #2504 from ZeroX-DG/pr-template

Added PR Template and update docs
This commit is contained in:
Junyoung Choi (Sai)
2018-11-19 15:14:02 +09:00
committed by GitHub
3 changed files with 133 additions and 3 deletions

82
docs/code_style.md Normal file
View File

@@ -0,0 +1,82 @@
# Boostnote Code Style
When submitting your PR, please make sure that your code is well tested and follow the code style of Boostnote.
The code style of Boostnote is listed in [`.eslintrc`](.eslintrc). We also have additional code styles that is not mentioned in that file.
## Additional code styles
### Use ES6 Object Destructing
Please use Object Destructing whenever it's possible.
**Example**: Importing from library
```js
// BAD
import Code from 'library'
const subCode = Code.subCode
subCode()
// GOOD
import { subCode } from 'library'
subCode()
```
**Example**: Extract data from react component state
```
// BAD
<h1>{this.state.name}</h1>
// GOOD
const { name } = this.state
<h1>{name}</h1>
```
### Use meaningful name
This is actually not a "code style" but rather a requirement in every projects. Please name your variables carefully.
**Example**: Naming callback function for event
```js
// BAD
<h1 onclick={onClick}>Name</h1>
// GOOD
<h1 onclick={onNameClick}>Name</h1>
```
### Don't write long conditional statement
When writing a conditional statement, if it's too long, cut it into small meaningful variables.
```js
// BAD
if (note.type == 'markdown' && note.index == 2 && note.content.indexOf('string') != -1)
// GOOD
const isSecondMarkdownNote = note.type == 'markdown' && note.index == 2
const isNoteHasString = note.content.indexOf('string') != -1
if (isSecondMarkdownNote && isNoteHasString)
```
### Use class property instead of class methods
When writing React components, try to use class property instead of class methods. The reason for this is explained perfectly here:
https://codeburst.io/use-class-properties-to-clean-up-your-classes-and-react-components-93185879f688
**Example**:
```js
// BAD
class MyComponent extends React.Component {
myMethod () {
// code goes here...
}
}
// GOOD
class MyComponent extends React.Component {
myMethod = () => {
// code goes here...
}
}
```