public/Boostnote
1
0
Fork 0
mirror of https://github.com/BoostIo/Boostnote synced 2025-12-13 17:56:25 +00:00
Code Issues Releases Wiki Activity

Merge pull request #1919 from samlanning/inconsistent-state-update

Browse Source 
fix inconsistent updates to react component state
This commit is contained in:
Junyoung Choi (Sai)
2018-05-15 19:30:22 +09:00
committed by GitHub
parent d69fd12fb9 0f354f4f06
commit b89896a4e7
2 changed files with 21 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
browser/components/SnippetTab.js
View File

@@ -55,10 +55,10 @@ class SnippetTab extends React.Component {
this.handleRename() this.handleRename()
break break
case 27: case 27:
this.setState({ this.setState((prevState, props) => ({
name: this.props.snippet.name, name: props.snippet.name,
isRenaming: false isRenaming: false
}) }))
break break
} }
} }

36
browser/main/Detail/SnippetNoteDetail.js
View File

@@ -368,11 +368,11 @@ class SnippetNoteDetail extends React.Component {
name: mode name: mode
}) })
} }
this.setState({note: Object.assign(this.state.note, {snippets: snippets})}) this.setState(state => ({note: Object.assign(state.note, {snippets: snippets})}))
this.setState({ this.setState(state => ({
note: this.state.note note: state.note
}, () => { }), () => {
this.save() this.save()
}) })
} }
@@ -381,11 +381,11 @@ class SnippetNoteDetail extends React.Component {
return (e) => { return (e) => {
const snippets = this.state.note.snippets.slice() const snippets = this.state.note.snippets.slice()
snippets[index].mode = name snippets[index].mode = name
this.setState({note: Object.assign(this.state.note, {snippets: snippets})}) this.setState(state => ({note: Object.assign(state.note, {snippets: snippets})}))
this.setState({ this.setState(state => ({
note: this.state.note note: state.note
}, () => { }), () => {
this.save() this.save()
}) })
@@ -399,10 +399,10 @@ class SnippetNoteDetail extends React.Component {
return (e) => { return (e) => {
const snippets = this.state.note.snippets.slice() const snippets = this.state.note.snippets.slice()
snippets[index].content = this.refs['code-' + index].value snippets[index].content = this.refs['code-' + index].value
this.setState({note: Object.assign(this.state.note, {snippets: snippets})}) this.setState(state => ({note: Object.assign(state.note, {snippets: snippets})}))
this.setState({ this.setState(state => ({
note: this.state.note note: state.note
}, () => { }), () => {
this.save() this.save()
}) })
} }
@@ -597,17 +597,17 @@ class SnippetNoteDetail extends React.Component {
} }
jumpNextTab () { jumpNextTab () {
this.setState({ this.setState(state => ({
snippetIndex: (this.state.snippetIndex + 1) % this.state.note.snippets.length snippetIndex: (state.snippetIndex + 1) % state.note.snippets.length
}, () => { }), () => {
this.focusEditor() this.focusEditor()
}) })
} }
jumpPrevTab () { jumpPrevTab () {
this.setState({ this.setState(state => ({
snippetIndex: (this.state.snippetIndex - 1 + this.state.note.snippets.length) % this.state.note.snippets.length snippetIndex: (state.snippetIndex - 1 + state.note.snippets.length) % state.note.snippets.length
}, () => { }), () => {
this.focusEditor() this.focusEditor()
}) })
} }