From bf4c9f920a023dd743474645564596bc7c886bab Mon Sep 17 00:00:00 2001 From: Kazu Yokomizo Date: Fri, 22 Sep 2017 15:13:34 +0900 Subject: [PATCH 1/8] Fix layout at preference modal --- browser/main/global.styl | 4 ++-- browser/main/modals/PreferencesModal/InfoTab.js | 7 ++++--- browser/main/modals/PreferencesModal/InfoTab.styl | 1 + browser/main/modals/PreferencesModal/PreferencesModal.styl | 7 ++++--- browser/styles/index.styl | 4 ++-- 5 files changed, 13 insertions(+), 10 deletions(-) diff --git a/browser/main/global.styl b/browser/main/global.styl index 552e0d6c..dfed8312 100644 --- a/browser/main/global.styl +++ b/browser/main/global.styl @@ -64,7 +64,7 @@ textarea.block-input fullsize() modalZIndex= 1000 -modalBackColor = transparentify(white, 65%) +modalBackColor = white .ace_focus outline-color rgb(59, 153, 252) outline-offset 0px @@ -86,7 +86,7 @@ modalBackColor = transparentify(white, 65%) body[data-theme="dark"] .ModalBase .modalBack - background-color alpha(black, 60%) + background-color $ui-dark-backgroundColor .CodeMirror font-family inherit !important diff --git a/browser/main/modals/PreferencesModal/InfoTab.js b/browser/main/modals/PreferencesModal/InfoTab.js index 35cd53a2..37be29dd 100644 --- a/browser/main/modals/PreferencesModal/InfoTab.js +++ b/browser/main/modals/PreferencesModal/InfoTab.js @@ -97,9 +97,10 @@ class InfoTab extends React.Component {
Data collection policy
-

We collect only the number of DAU for Boostnote and DO NOT collect any detail information

-

such as your note content. You can see how it works on this.handleLinkClick(e)}>GitHub.

-

These data are only used for Boostnote improvements.

+
We collect only the number of DAU for Boostnote and **DO NOT collect** any detail information such as your note content.
+
You can see how it works on this.handleLinkClick(e)}>GitHub.
+
 
+
These data are only used for Boostnote improvements.
this.handleConfigChange(e)} checked={this.state.config.amaEnabled} ref='amaEnabled' diff --git a/browser/main/modals/PreferencesModal/InfoTab.styl b/browser/main/modals/PreferencesModal/InfoTab.styl index 6158c634..176405f4 100644 --- a/browser/main/modals/PreferencesModal/InfoTab.styl +++ b/browser/main/modals/PreferencesModal/InfoTab.styl @@ -43,6 +43,7 @@ text-decoration none .policy + width 100% font-size 20px margin-bottom 10px diff --git a/browser/main/modals/PreferencesModal/PreferencesModal.styl b/browser/main/modals/PreferencesModal/PreferencesModal.styl index a0a670b5..712b0736 100644 --- a/browser/main/modals/PreferencesModal/PreferencesModal.styl +++ b/browser/main/modals/PreferencesModal/PreferencesModal.styl @@ -4,9 +4,10 @@ top-bar--height = 50px .root modal() - max-width 800px - min-height 500px - height 80% + max-width 100vw + min-height 100vh + height 100vh + width 100vw overflow hidden position relative diff --git a/browser/styles/index.styl b/browser/styles/index.styl index 8df338c0..3fcd383d 100644 --- a/browser/styles/index.styl +++ b/browser/styles/index.styl @@ -150,10 +150,11 @@ modal() position relative z-index $modal-z-index width 100% + margin-left 40px + margin-right 40px background-color $modal-background overflow hidden border-radius $modal-border-radius - box-shadow 0 0 1px rgba(76,86,103,.15), 0 2px 18px rgba(31,37,50,.22) topBarButtonLight() width 34px @@ -260,4 +261,3 @@ modalDark() background-color $ui-dark-backgroundColor overflow hidden border-radius $modal-border-radius - box-shadow 2px 2px 10px black From fc552e030a1d03efde07e401b86829fbf02e9e51 Mon Sep 17 00:00:00 2001 From: Kazu Yokomizo Date: Fri, 22 Sep 2017 15:21:04 +0900 Subject: [PATCH 2/8] Change save button position to top --- browser/main/modals/PreferencesModal/ConfigTab.styl | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/browser/main/modals/PreferencesModal/ConfigTab.styl b/browser/main/modals/PreferencesModal/ConfigTab.styl index 11114272..75c8b0b4 100644 --- a/browser/main/modals/PreferencesModal/ConfigTab.styl +++ b/browser/main/modals/PreferencesModal/ConfigTab.styl @@ -77,14 +77,16 @@ margin-right 10px .group-control-rightButton - float right + position absolute + top 10px + right 20px colorPrimaryButton() border none border-radius 2px font-size $tab--button-font-size - height 35px - width 100px - margin-right 10px + height 40px + width 120px + padding 0 15px .group-hint border $ui-border From 31485d3387f29b7621a072fb618e191b79c3c69b Mon Sep 17 00:00:00 2001 From: Kazu Yokomizo Date: Fri, 22 Sep 2017 15:27:22 +0900 Subject: [PATCH 3/8] Fix layout at head in PreferenceModal --- browser/components/ModalEscButton.js | 2 +- browser/components/ModalEscButton.styl | 4 +++- browser/main/modals/PreferencesModal/Tab.styl | 4 ++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/browser/components/ModalEscButton.js b/browser/components/ModalEscButton.js index 190b7ccd..42fe9100 100644 --- a/browser/components/ModalEscButton.js +++ b/browser/components/ModalEscButton.js @@ -6,7 +6,7 @@ const ModalEscButton = ({ handleEscButtonClick }) => ( ) diff --git a/browser/components/ModalEscButton.styl b/browser/components/ModalEscButton.styl index 378fac85..12cd56ed 100644 --- a/browser/components/ModalEscButton.styl +++ b/browser/components/ModalEscButton.styl @@ -11,4 +11,6 @@ height top-bar-height .esc-mark - font-size 15px + font-size 28px + margin-top -5px + margin-bottom -7px \ No newline at end of file diff --git a/browser/main/modals/PreferencesModal/Tab.styl b/browser/main/modals/PreferencesModal/Tab.styl index 7280407b..3b722cbf 100644 --- a/browser/main/modals/PreferencesModal/Tab.styl +++ b/browser/main/modals/PreferencesModal/Tab.styl @@ -10,8 +10,8 @@ $tab--button-font-size = 14px $tab--dark-text-color = #E5E5E5 .header - font-size 24px - margin-bottom 30px + font-size 36px + margin-bottom 60px body[data-theme="dark"] .header From beceb851c24d6f62879923d0d365e158f075f9e9 Mon Sep 17 00:00:00 2001 From: Kazu Yokomizo Date: Fri, 22 Sep 2017 15:41:40 +0900 Subject: [PATCH 4/8] Fix layout at selector size in PreferenceModal --- browser/main/modals/PreferencesModal/ConfigTab.styl | 4 ++++ browser/main/modals/PreferencesModal/UiTab.js | 3 +-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/browser/main/modals/PreferencesModal/ConfigTab.styl b/browser/main/modals/PreferencesModal/ConfigTab.styl index 75c8b0b4..968abef9 100644 --- a/browser/main/modals/PreferencesModal/ConfigTab.styl +++ b/browser/main/modals/PreferencesModal/ConfigTab.styl @@ -35,6 +35,10 @@ .group-section-control select outline none border 1px solid $ui-borderColor + font-size 16px + height 30px + width 250px + margin-bottom 5px background-color transparent .group-section-control-input diff --git a/browser/main/modals/PreferencesModal/UiTab.js b/browser/main/modals/PreferencesModal/UiTab.js index 96c04ddf..0b911b49 100644 --- a/browser/main/modals/PreferencesModal/UiTab.js +++ b/browser/main/modals/PreferencesModal/UiTab.js @@ -90,9 +90,8 @@ class UiTab extends React.Component {
UI
-
Theme
-
+ Color Theme 
this.handleConfigChange(e)} checked={this.state.config.amaEnabled} diff --git a/browser/main/modals/PreferencesModal/UiTab.js b/browser/main/modals/PreferencesModal/UiTab.js index 0b911b49..7bbd3e8c 100644 --- a/browser/main/modals/PreferencesModal/UiTab.js +++ b/browser/main/modals/PreferencesModal/UiTab.js @@ -91,7 +91,7 @@ class UiTab extends React.Component {
UI
- Color Theme  + Color Theme