public/Boostnote
1
0
Fork 0
mirror of https://github.com/BoostIo/Boostnote synced 2025-12-13 09:46:22 +00:00
Code Issues Releases Wiki Activity

Cloning of a note should also clone its attachments -> works if the notes are in different storages now

Browse Source
This commit is contained in:
ehhc
2018-05-20 15:49:15 +02:00
parent f76224bd17
commit cd6233a3d7
3 changed files with 26 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
browser/main/NoteList/index.js
View File

@@ -664,7 +664,7 @@ class NoteList extends React.Component {
content: firstNote.content
})
.then((note) => {
attachmentManagement.cloneAttachments(storage.key, firstNote, note)
attachmentManagement.cloneAttachments(firstNote, note)
return note
})
.then((note) => {

12
browser/main/lib/dataApi/attachmentManagement.js
View File

@@ -284,21 +284,21 @@ function deleteAttachmentsNotPresentInNote (markdownContent, storageKey, noteKey
/**
* Clones the attachments of a given note.
* Copies the attachments to their new destination and updates the content of the new note so that the attachment-links again point to the correct destination.
* @param storageKey Key of the current storage
* @param oldNote Note that is being cloned
* @param newNote Clone of the note
*/
function cloneAttachments (storageKey, oldNote, newNote) {
const storage = findStorage.findStorage(storageKey)
const attachmentsPaths = getAbsolutePathsOfAttachmentsInContent(oldNote.content, storage.path) || []
function cloneAttachments (oldNote, newNote) {
const oldStorage = findStorage.findStorage(oldNote.storage)
const newStorage = findStorage.findStorage(newNote.storage)
const attachmentsPaths = getAbsolutePathsOfAttachmentsInContent(oldNote.content, oldStorage.path) || []
const destinationFolder = path.join(storage.path, DESTINATION_FOLDER, newNote.key)
const destinationFolder = path.join(newStorage.path, DESTINATION_FOLDER, newNote.key)
if (!sander.existsSync(destinationFolder)) {
sander.mkdirSync(destinationFolder)
}
for (const attachment of attachmentsPaths) {
const destination = path.join(storage.path, DESTINATION_FOLDER, newNote.key, path.basename(attachment))
const destination = path.join(newStorage.path, DESTINATION_FOLDER, newNote.key, path.basename(attachment))
sander.copyFileSync(attachment).to(destination)
}
newNote.content = replaceNoteKeyWithNewNoteKey(newNote.content, oldNote.key, newNote.key)