added fetch snippet

refactored some code

fixed snippet content empty on changed from list

fixed snippet name not updating on list when changed

browser/main/lib/dataApi/createSnippet.js

@@ -1,9 +1,11 @@
 import fs from 'fs'
 import crypto from 'crypto'
 import consts from 'browser/lib/consts'
+import fetchSnippet from 'browser/main/lib/dataApi/fetchSnippet'
 
-function createSnippet (snippets) {
+function createSnippet () {
   return new Promise((resolve, reject) => {
+    fetchSnippet().then((snippets) => {
       const newSnippet = {
         id: crypto.randomBytes(16).toString('hex'),
         name: 'Unnamed snippet',
@@ -13,7 +15,8 @@ function createSnippet (snippets) {
       snippets.push(newSnippet)
       fs.writeFile(consts.SNIPPET_FILE, JSON.stringify(snippets, null, 4), (err) => {
         if (err) reject(err)
-      resolve(snippets)
+        resolve(newSnippet)
+      })
     })
   })
 }

browser/main/lib/dataApi/deleteSnippet.js

@@ -1,17 +1,16 @@
 import fs from 'fs'
 import consts from 'browser/lib/consts'
+import fetchSnippet from 'browser/main/lib/dataApi/fetchSnippet'
 
-function deleteSnippet (snippets, snippetId) {
+function deleteSnippet (snippet) {
   return new Promise((resolve, reject) => {
-    for (let i = 0; i < snippets.length; i++) {
-      if (snippets[i].id === snippetId) {
-        snippets.splice(i, 1)
+    fetchSnippet().then((snippets) => {
+      snippets = snippets.filter(currentSnippet => currentSnippet.id !== snippet.id)
       fs.writeFile(consts.SNIPPET_FILE, JSON.stringify(snippets, null, 4), (err) => {
         if (err) reject(err)
-          resolve(snippets)
+        resolve(snippet)
+      })
     })
-      }
-    }
   })
 }
 

browser/main/lib/dataApi/fetchSnippet.js

@@ -0,0 +1,21 @@
+import fs from 'fs'
+import crypto from 'crypto'
+import consts from 'browser/lib/consts'
+
+function fetchSnippet (id) {
+  return new Promise((resolve, reject) => {
+    fs.readFile(consts.SNIPPET_FILE, 'utf8', (err, data) => {
+      if (err) {
+        reject(err)
+      }
+      const snippets = JSON.parse(data)
+      if (id) {
+        const snippet = snippets.find(snippet => { return snippet.id === id })
+        resolve(snippet)
+      }
+      resolve(snippets)
+    })
+  })
+}
+
+module.exports = fetchSnippet

browser/main/lib/dataApi/index.js

@@ -16,6 +16,7 @@ const dataApi = {
   createSnippet: require('./createSnippet'),
   deleteSnippet: require('./deleteSnippet'),
   updateSnippet: require('./updateSnippet'),
+  fetchSnippet: require('./fetchSnippet'),
 
   _migrateFromV6Storage: require('./migrateFromV6Storage'),
   _resolveStorageData: require('./resolveStorageData'),

browser/main/modals/PreferencesModal/SnippetEditor.js

@@ -12,6 +12,7 @@ const buildCMRulers = (rulers, enableRulers) =>
 export default class SnippetEditor extends React.Component {
 
   componentDidMount () {
+    this.props.onRef(this)
     const { rulers, enableRulers } = this.props
     this.cm = CodeMirror(this.refs.root, {
       rulers: buildCMRulers(rulers, enableRulers),
@@ -29,9 +30,6 @@ export default class SnippetEditor extends React.Component {
       autoCloseBrackets: true
     })
     this.cm.setSize('100%', '100%')
-    this.snippet = this.props.snippet
-    const snippetId = this.snippet.id
-    this.loadSnippet(snippetId)
     let changeDelay = null
 
     this.cm.on('change', () => {
@@ -44,30 +42,23 @@ export default class SnippetEditor extends React.Component {
     })
   }
 
-  saveSnippet () {
-    dataApi.updateSnippet(this.snippet).catch((err) => { throw err })
+  componentWillUnmount () {
+    this.props.onRef(undefined)
   }
 
-  loadSnippet (snippetId) {
-    const snippets = JSON.parse(fs.readFileSync(consts.SNIPPET_FILE, 'utf8'))
-
-    for (let i = 0; i < snippets.length; i++) {
-      if (snippets[i].id === snippetId) {
-        this.cm.setValue(snippets[i].content)
-      }
-    }
+  onSnippetChanged (newSnippet) {
+    this.snippet = newSnippet
+    this.cm.setValue(this.snippet.content)
   }
 
-  componentWillReceiveProps (newProps) {
-    if (this.snippet.id !== newProps.snippet.id) {
-      // when user changed to a new snippet on the snippetList.js
-      this.loadSnippet(newProps.snippet.id)
-    } else {
-      // when snippet name or prefix being changed from snippetTab.js
-      this.snippet.name = newProps.snippet.name
-      this.snippet.prefix = newProps.snippet.prefix.replace(/\s/g, '').split(/\,/).filter(val => val)
+  onSnippetNameOrPrefixChanged (newSnippet) {
+    this.snippet.name = newSnippet.name
+    this.snippet.prefix = newSnippet.prefix.toString().replace(/\s/g, '').split(',')
     this.saveSnippet()
   }
+
+  saveSnippet () {
+    dataApi.updateSnippet(this.snippet).catch((err) => { throw err })
   }
 
   render () {

browser/main/modals/PreferencesModal/SnippetTab.js

@@ -19,18 +19,30 @@ class SnippetTab extends React.Component {
       snippets: [],
       currentSnippet: null
     }
+    this.changeDelay = null
   }
 
   componentDidMount () {
-    this.snippets = JSON.parse(fs.readFileSync(consts.SNIPPET_FILE, 'utf8'))
-
-    this.setState({snippets: this.snippets})
+    this.reloadSnippetList()
   }
 
   handleSnippetClick (snippet) {
-    const currentSnippet = Object.assign({}, snippet)
-    currentSnippet.prefix = currentSnippet.prefix.join(', ')
-    this.setState({currentSnippet})
+    if (this.state.currentSnippet === null || this.state.currentSnippet.id !== snippet.id) {
+      dataApi.fetchSnippet(snippet.id).then(changedSnippet => {
+        // notify the snippet editor to load the content of the new snippet
+        this.snippetEditor.onSnippetChanged(changedSnippet)
+        this.setState({currentSnippet: changedSnippet})
+      })
+    }
+  }
+
+  handleSnippetNameOrPrefixChange () {
+    clearTimeout(this.changeDelay)
+    this.changeDelay = setTimeout(() => {
+      // notify the snippet editor that the name or prefix of snippet has been changed
+      this.snippetEditor.onSnippetNameOrPrefixChanged(this.state.currentSnippet)
+      this.reloadSnippetList()
+    }, 500)
   }
 
   handleSnippetContextMenu (snippet) {
@@ -38,23 +50,25 @@ class SnippetTab extends React.Component {
     menu.append(new MenuItem({
       label: i18n.__('Delete snippet'),
       click: () => {
-        this.deleteSnippet(snippet.id)
+        this.deleteSnippet(snippet)
       }
     }))
     menu.popup()
   }
 
-  deleteSnippet (id) {
-    dataApi.deleteSnippet(this.snippets, id).then((snippets) => {
-      this.snippets = snippets
-      this.setState(this.snippets)
+  reloadSnippetList () {
+    dataApi.fetchSnippet().then(snippets => this.setState({snippets}))
+  }
+
+  deleteSnippet (snippet) {
+    dataApi.deleteSnippet(snippet).then(() => {
+      this.reloadSnippetList()
     }).catch(err => { throw err })
   }
 
   createSnippet () {
-    dataApi.createSnippet(this.snippets).then((snippets) => {
-      this.snippets = snippets
-      this.setState(this.snippets)
+    dataApi.createSnippet().then(() => {
+      this.reloadSnippetList()
       // scroll to end of list when added new snippet
       const snippetList = document.getElementById('snippets')
       snippetList.scrollTop = snippetList.scrollHeight
@@ -100,17 +114,18 @@ class SnippetTab extends React.Component {
           </div>
           {this.renderSnippetList()}
         </div>
-        {this.state.currentSnippet ? <div styleName='snippet-detail'>
+        <div styleName='snippet-detail' style={{visibility: this.state.currentSnippet ? 'visible' : 'hidden'}}>
           <div styleName='group-section'>
             <div styleName='group-section-label'>{i18n.__('Snippet name')}</div>
             <div styleName='group-section-control'>
               <input
                 styleName='group-section-control-input'
-                value={this.state.currentSnippet.name}
+                value={this.state.currentSnippet ? this.state.currentSnippet.name : ''}
                 onChange={e => {
                   const newSnippet = Object.assign({}, this.state.currentSnippet)
                   newSnippet.name = e.target.value
                   this.setState({ currentSnippet: newSnippet })
+                  this.handleSnippetNameOrPrefixChange()
                 }}
                 type='text' />
             </div>
@@ -120,11 +135,12 @@ class SnippetTab extends React.Component {
             <div styleName='group-section-control'>
               <input
                 styleName='group-section-control-input'
-                value={this.state.currentSnippet.prefix}
+                value={this.state.currentSnippet ? this.state.currentSnippet.prefix : ''}
                 onChange={e => {
                   const newSnippet = Object.assign({}, this.state.currentSnippet)
                   newSnippet.prefix = e.target.value
                   this.setState({ currentSnippet: newSnippet })
+                  this.handleSnippetNameOrPrefixChange()
                 }}
                 type='text' />
             </div>
@@ -142,10 +158,9 @@ class SnippetTab extends React.Component {
               rulers={config.editor.rulers}
               displayLineNumbers={config.editor.displayLineNumbers}
               scrollPastEnd={config.editor.scrollPastEnd}
-              snippet={this.state.currentSnippet} />
+              onRef={ref => this.snippetEditor = ref} />
           </div>
         </div>
-        : ''}
       </div>
     )
   }