renew renameStorage api

browser/main/lib/dataApi/renameStorage.js

@@ -8,24 +8,20 @@ const _ = require('lodash')
 function renameStorage (key, name) {
   if (!_.isString(name)) return Promise.reject(new Error('Name must be a string.'))
 
-  let rawStorages
+  let cachedStorageList
   try {
-    rawStorages = JSON.parse(localStorage.getItem('storages'))
-    if (!_.isArray(rawStorages)) throw new Error('invalid storages')
-  } catch (e) {
-    console.warn(e)
-    rawStorages = []
+    cachedStorageList = JSON.parse(localStorage.getItem('storages'))
+    if (!_.isArray(cachedStorageList)) throw new Error('invalid storages')
+  } catch (err) {
+    console.log('error got')
+    console.error(err)
+    return Promise.reject(err)
   }
+  let targetStorage = _.find(cachedStorageList, {key: key})
+  if (targetStorage == null) return Promise.reject('Storage')
 
-  let targetStorage
-  for (let i = 0; i < rawStorages.length; i++) {
-    if (rawStorages[i].key === key) {
-      rawStorages[i].name = name
-      targetStorage = rawStorages[i]
-    }
-  }
-
-  localStorage.setItem('storages', JSON.stringify(rawStorages))
+  targetStorage.name = name
+  localStorage.setItem('storages', JSON.stringify(cachedStorageList))
 
   return Promise.resolve(targetStorage)
 }