From ec47ee8110cc42a884cc8b5b6a1f1346dc53a9a2 Mon Sep 17 00:00:00 2001 From: AWolf81 Date: Sat, 31 Aug 2019 21:35:09 +0200 Subject: [PATCH] Remove manual script tag filter and use turndown remove filter --- browser/lib/turndown.js | 1 + browser/main/lib/dataApi/createNoteFromUrl.js | 13 +------------ 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/browser/lib/turndown.js b/browser/lib/turndown.js index 085203a1..a1c3e128 100644 --- a/browser/lib/turndown.js +++ b/browser/lib/turndown.js @@ -4,5 +4,6 @@ const { gfm } = require('turndown-plugin-gfm') export const createTurndownService = function () { const turndown = new TurndownService() turndown.use(gfm) + turndown.remove('script') return turndown } diff --git a/browser/main/lib/dataApi/createNoteFromUrl.js b/browser/main/lib/dataApi/createNoteFromUrl.js index 2897db0d..f9878210 100644 --- a/browser/main/lib/dataApi/createNoteFromUrl.js +++ b/browser/main/lib/dataApi/createNoteFromUrl.js @@ -32,18 +32,7 @@ function createNoteFromUrl (url, storage, folder, dispatch = null, location = nu }) res.on('end', () => { - const html = document.createElement('html') - html.innerHTML = data - - const scripts = html.getElementsByTagName('script') - for (let i = scripts.length - 1; i >= 0; i--) { - scripts[i].parentNode.removeChild(scripts[i]) - } - - const body = html.getElementsByTagName('body')[0].innerHTML - const markdownHTML = td.turndown(body) - - html.innerHTML = '' + const markdownHTML = td.turndown(data) if (dispatch !== null) { createNote(storage, {