Duarte-Frazao
a9442a019f
Changes to pass tests and lint code
2018-11-30 19:20:40 +00:00
Duarte-Frazao
45436f65af
Issue #2469 almost done, missing refactor to reduce calls on code mirror
2018-11-30 18:03:23 +00:00
Baptiste Augrain
900f20f164
handle all dropped images
2018-11-28 15:58:58 +01:00
Baptiste Augrain
c2e4bae9dd
fix regex to correctly match the src attribute when there is a data-src attribute
2018-11-28 15:00:29 +01:00
Baptiste Augrain
9050035c74
- add option to enable/disable smart paste
...
- add shortcut to paste smartly
- use electron's clipboard
2018-11-28 00:44:15 +01:00
Baptiste Augrain
64f7233bfc
fix regex to match :storage reference, added comment to explain what it does.
2018-11-25 16:58:11 +01:00
Baptiste Augrain
9d81e4be2f
undo change
2018-11-25 16:17:01 +01:00
Baptiste Augrain
2908884202
drag and drop image from browser
2018-11-25 15:56:11 +01:00
Baptiste Augrain
b1a7f0fd64
Merge branch 'master' into gallery
2018-11-08 23:52:31 +01:00
Junyoung Choi (Sai)
cfc84f3e78
Merge pull request #2434 from jacobherrington/chore-remove-console-logs
...
Remove console.logs
2018-11-06 15:49:07 +09:00
Baptiste Augrain
7a5a821f8a
fix failing test
2018-10-09 00:47:37 +02:00
Baptiste Augrain
39eaed260a
display correctly attached image
2018-10-08 15:57:42 +02:00
Sam Herrington
ca69bd69f2
Remove unnecessary conditional logic
...
In reference to PR feedback.
2018-09-30 17:46:38 -05:00
Junyoung Choi (Sai)
2ccd00a378
Merge pull request #2322 from youngyou/fix-drop-image-rotate
...
Fix drop image rotate wrong
2018-10-01 03:48:54 +09:00
samherrington
dd913279d7
Fixup for errors
2018-09-29 15:57:02 -05:00
samherrington
1246a677d1
Remove console.logs
...
Using console in production is generally undesirable due to
performance loss and security concerns. Errors were changed
to console.error and console.logs were removed.
2018-09-29 15:50:32 -05:00
ehhc
d79b6e094a
export folder should also export the attachments -> fixes #2374
2018-09-09 17:41:51 +02:00
Keyon U
2bbcb8ca89
Add comments for the “rotate fix”
2018-08-22 18:03:02 +08:00
Keyon U
48beb184df
Fix drop image rotate wrong
...
Fix drag-drop image rotate wrong, as Jordan Thornquest mentioned in slack
2018-08-22 12:23:45 +08:00
zhoufeng1989
b93d7a204f
Fix 2207 and 2273, add export for storage.
2018-08-14 12:38:31 +12:00
Maciek
4a3bcaba06
BUG FIX: Change the way of checking for empty array
...
The original condition : attachments !== [] always returns true,
for empty array, as well as for array with elements.
2018-07-28 22:25:10 +02:00
Maciek
1d1ab65edd
BUG FIX: snippet notes are not displaying in markdown #2088
...
Fix for issue https://github.com/BoostIo/Boostnote/issues/2088 .
In specific situation, when all below conditions are met :
- one of the snippets notes tabs is a Markdown tab,
- the migrateAttachments code is called on a snippet note,
- historical attachments location '/images' exists in snippet storage
folder
Following exception is being thrown :
path.js:28 Uncaught TypeError: Path must be a string. Received undefined
The exception is a result of an undefined noteKey variable
(which is defined only for Markdown notes).
The solution is to skip migration of attachments for notes without
noteKey (which wouldn't be possible anyway, since noteKey is a
necessary for creating folder for attachments).
2018-07-28 22:23:14 +02:00
Santiago Agüero
c37b780ca4
Use markdown content for migrateAttachments
2018-07-17 00:13:13 -03:00
Santiago Agüero
5cc52f91cb
Fix lint errors
2018-07-15 12:07:27 -03:00
Santiago Agüero
a46b9fb2be
Fix attachment interop between win and nix
2018-07-15 01:37:47 -03:00
Kelvin Wong
8a6c86bf65
Add collapsed state for storage
...
The root cause of this issue is that when the folder is clicked,
the router pushed the path and the StorageItem component has been
refreshed and isOpen has been reset
- Add storing collapse state for storage
- Add tests
- Default as collapsed for fallback
fix BoostIo/Boostnote#1979 BoostIo/Boostnote#1911
2018-06-28 13:08:39 +08:00
ehhc
c69f34836a
handle dot in file name
2018-06-25 15:18:45 +02:00
ehhc
7970016fbf
One more try to fix the handling of images in the legacy location
2018-06-20 08:48:55 +02:00
ehhc
5d62dd2002
Merge branch 'master' of https://github.com/BoostIO/Boostnote into paste_storage_link_should_clone_attachment
...
# Conflicts:
# browser/main/lib/dataApi/attachmentManagement.js
# locales/da.json
# locales/de.json
# locales/en.json
# locales/es-ES.json
# locales/fa.json
# locales/fr.json
# locales/hu.json
# locales/it.json
# locales/ja.json
# locales/ko.json
# locales/no.json
# locales/pl.json
# locales/pt-BR.json
# locales/pt-PT.json
# locales/ru.json
# locales/sq.json
# locales/zh-CN.json
# locales/zh-TW.json
2018-06-06 12:03:53 +02:00
Junyoung Choi (Sai)
88856b788a
Merge pull request #1963 from ehhc/OnBlur_Throws_Exceptions_On_Snippet_Notes
...
OnBlur throws exceptions if the notetype is snippet -> Fixes #1962
2018-06-06 11:11:27 +09:00
ehhc
22e2c3da1f
Merge branch 'master' of https://github.com/BoostIO/Boostnote into paste_storage_link_should_clone_attachment
...
# Conflicts:
# browser/components/CodeEditor.js
# browser/main/lib/dataApi/attachmentManagement.js
2018-06-05 11:28:42 +02:00
ehhc
b526d48946
CodeReview
2018-06-05 11:16:50 +02:00
ehhc
ffae53326a
Fix for the issues raised in the code review
2018-06-04 11:55:23 +09:00
ehhc
ddd1522e19
Pasting an image should insert a relative attachment file link -> fixes #1953
2018-06-04 11:55:23 +09:00
ehhc
4bc0cccb24
Migrate attachments from /images to /attachments -> fix #1941
2018-06-04 11:55:23 +09:00
ehhc
9c247bcb22
Copying the link to an attachment should make sure that it is located in the same note folder -> Fixes #1924
2018-05-29 17:20:14 +02:00
ehhc
2fce78422b
Merge branch 'master' into OnBlur_Throws_Exceptions_On_Snippet_Notes
2018-05-28 09:00:57 +02:00
ehhc
8132dd6847
Fix for the issues raised in the code review
2018-05-28 08:58:09 +02:00
Nguyễn Việt Hưng
c2c50817f1
resolved conflict
2018-05-25 18:42:02 +07:00
Junyoung Choi (Sai)
0d296c3b25
Merge pull request #1936 from ehhc/delete_folder
...
deleting a folder should also delete the attachments -> fixes #1903
2018-05-24 14:45:47 +09:00
ehhc
2f4eb595f6
OnBlur throws exceptions if the notetype is snippet -> Fixes #1962
2018-05-23 19:47:41 +02:00
ehhc
bfcf349ffe
Attachment management should only become active on cloning notes if the note was of type MARKDOWN_NOTE -> No Stacktraces otherwise!
2018-05-23 19:24:03 +02:00
Nguyễn Việt Hưng
2b2f17525e
cleaned up redundant variables, fixed eslint fix command, split snippetList into component
2018-05-21 18:32:41 +07:00
ehhc
cd6233a3d7
Cloning of a note should also clone its attachments -> works if the notes are in different storages now
2018-05-20 15:49:15 +02:00
ehhc
f76224bd17
Cloning of a note should also clone its attachments -> fixes #1904
2018-05-20 15:18:49 +02:00
ehhc
8afa373726
Attachments should be visible immediately
2018-05-20 13:55:10 +02:00
ehhc
86a6311f75
deleting a folder should also delete the attachments -> fixes #1903
2018-05-19 20:38:10 +02:00
Junyoung Choi (Sai)
d3091a5384
Merge branch 'master' into Moving_Note_With_Attachment
2018-05-17 01:28:47 +09:00
ehhc
007d3e52c5
Merge branch 'master' into Issue_1900
2018-05-15 20:26:10 +02:00
ehhc
f10fa632ca
Move note with attachment to different storage Fix for #1788
2018-05-15 20:17:32 +02:00