anasasilva
3d6f670e8d
regex fixed again
2019-04-08 21:10:42 +09:00
anasasilva
9d47f319a0
absolute path
2019-04-08 21:10:42 +09:00
anasasilva
7106f042da
Regex fixed
2019-04-08 21:10:42 +09:00
anasasilva
ea6e56842f
Error message when the image path is wrong
2019-04-08 21:10:42 +09:00
anasasilva
65926fea73
fixing identation and regex
2019-04-08 21:10:42 +09:00
anasasilva
85cb94d99d
importAttachments
2019-04-08 21:10:42 +09:00
Baptiste Augrain
e0d9cf7f5c
fix dropping image from Firefox on Linux
2019-02-04 18:22:10 +01:00
Baptiste Augrain
10ea5d00eb
avoid converting SVG
2019-02-04 14:09:11 +01:00
Baptiste Augrain
de76f55fe2
fix gif
2019-02-04 13:54:45 +01:00
Baptiste Augrain
cd301d514c
Merge branch 'master' into drop-browser-image
2019-02-04 13:36:32 +01:00
Junyoung Choi
53ff693e95
Merge pull request #2852 from Aaron-Bird/bug-gif
...
[Fix] GIFs don't animate
2019-02-04 12:25:28 +09:00
Baptiste Augrain
215484c19a
add tests
2019-02-01 16:27:47 +01:00
Baptiste Augrain
851d3ba159
fix image path when the dropped image's url contains a query
2019-01-31 23:26:31 +01:00
Aaron-Bird
806139091c
fix: GIFs don't animate
2019-01-31 01:08:07 +08:00
Baptiste Augrain
a85a27f225
- fix bad regex
...
- improve test
- fix missing 'e' in some functions name
2019-01-29 16:05:30 +01:00
ehhc
7165c4550b
possibly fix for the broken test...
2019-01-26 18:16:39 +01:00
ehhc
472496d59c
possibly fix for the broken test...
2019-01-26 17:53:31 +01:00
ehhc
127da40256
possibly fix for the broken test...
2019-01-26 17:37:04 +01:00
ehhc
a113b99de0
Strange url-handling reverted + tests modified so that they might find that issue in the future + test modified so that they both contain tests for posix and windows path separator -> fixes #2834
2019-01-26 17:21:53 +01:00
Junyoung Choi
5f385e4c03
Merge pull request #2465 from daiyam/gallery
...
add image gallery
2018-12-24 17:19:03 +09:00
Baptiste Augrain
900f20f164
handle all dropped images
2018-11-28 15:58:58 +01:00
Baptiste Augrain
c2e4bae9dd
fix regex to correctly match the src attribute when there is a data-src attribute
2018-11-28 15:00:29 +01:00
Baptiste Augrain
9050035c74
- add option to enable/disable smart paste
...
- add shortcut to paste smartly
- use electron's clipboard
2018-11-28 00:44:15 +01:00
Baptiste Augrain
64f7233bfc
fix regex to match :storage reference, added comment to explain what it does.
2018-11-25 16:58:11 +01:00
Baptiste Augrain
9d81e4be2f
undo change
2018-11-25 16:17:01 +01:00
Baptiste Augrain
2908884202
drag and drop image from browser
2018-11-25 15:56:11 +01:00
Baptiste Augrain
b1a7f0fd64
Merge branch 'master' into gallery
2018-11-08 23:52:31 +01:00
Junyoung Choi (Sai)
cfc84f3e78
Merge pull request #2434 from jacobherrington/chore-remove-console-logs
...
Remove console.logs
2018-11-06 15:49:07 +09:00
Baptiste Augrain
7a5a821f8a
fix failing test
2018-10-09 00:47:37 +02:00
Baptiste Augrain
39eaed260a
display correctly attached image
2018-10-08 15:57:42 +02:00
samherrington
1246a677d1
Remove console.logs
...
Using console in production is generally undesirable due to
performance loss and security concerns. Errors were changed
to console.error and console.logs were removed.
2018-09-29 15:50:32 -05:00
Keyon U
2bbcb8ca89
Add comments for the “rotate fix”
2018-08-22 18:03:02 +08:00
Keyon U
48beb184df
Fix drop image rotate wrong
...
Fix drag-drop image rotate wrong, as Jordan Thornquest mentioned in slack
2018-08-22 12:23:45 +08:00
Maciek
4a3bcaba06
BUG FIX: Change the way of checking for empty array
...
The original condition : attachments !== [] always returns true,
for empty array, as well as for array with elements.
2018-07-28 22:25:10 +02:00
Maciek
1d1ab65edd
BUG FIX: snippet notes are not displaying in markdown #2088
...
Fix for issue https://github.com/BoostIo/Boostnote/issues/2088 .
In specific situation, when all below conditions are met :
- one of the snippets notes tabs is a Markdown tab,
- the migrateAttachments code is called on a snippet note,
- historical attachments location '/images' exists in snippet storage
folder
Following exception is being thrown :
path.js:28 Uncaught TypeError: Path must be a string. Received undefined
The exception is a result of an undefined noteKey variable
(which is defined only for Markdown notes).
The solution is to skip migration of attachments for notes without
noteKey (which wouldn't be possible anyway, since noteKey is a
necessary for creating folder for attachments).
2018-07-28 22:23:14 +02:00
Santiago Agüero
c37b780ca4
Use markdown content for migrateAttachments
2018-07-17 00:13:13 -03:00
Santiago Agüero
5cc52f91cb
Fix lint errors
2018-07-15 12:07:27 -03:00
Santiago Agüero
a46b9fb2be
Fix attachment interop between win and nix
2018-07-15 01:37:47 -03:00
ehhc
c69f34836a
handle dot in file name
2018-06-25 15:18:45 +02:00
ehhc
7970016fbf
One more try to fix the handling of images in the legacy location
2018-06-20 08:48:55 +02:00
ehhc
5d62dd2002
Merge branch 'master' of https://github.com/BoostIO/Boostnote into paste_storage_link_should_clone_attachment
...
# Conflicts:
# browser/main/lib/dataApi/attachmentManagement.js
# locales/da.json
# locales/de.json
# locales/en.json
# locales/es-ES.json
# locales/fa.json
# locales/fr.json
# locales/hu.json
# locales/it.json
# locales/ja.json
# locales/ko.json
# locales/no.json
# locales/pl.json
# locales/pt-BR.json
# locales/pt-PT.json
# locales/ru.json
# locales/sq.json
# locales/zh-CN.json
# locales/zh-TW.json
2018-06-06 12:03:53 +02:00
Junyoung Choi (Sai)
88856b788a
Merge pull request #1963 from ehhc/OnBlur_Throws_Exceptions_On_Snippet_Notes
...
OnBlur throws exceptions if the notetype is snippet -> Fixes #1962
2018-06-06 11:11:27 +09:00
ehhc
22e2c3da1f
Merge branch 'master' of https://github.com/BoostIO/Boostnote into paste_storage_link_should_clone_attachment
...
# Conflicts:
# browser/components/CodeEditor.js
# browser/main/lib/dataApi/attachmentManagement.js
2018-06-05 11:28:42 +02:00
ehhc
b526d48946
CodeReview
2018-06-05 11:16:50 +02:00
ehhc
ffae53326a
Fix for the issues raised in the code review
2018-06-04 11:55:23 +09:00
ehhc
ddd1522e19
Pasting an image should insert a relative attachment file link -> fixes #1953
2018-06-04 11:55:23 +09:00
ehhc
4bc0cccb24
Migrate attachments from /images to /attachments -> fix #1941
2018-06-04 11:55:23 +09:00
ehhc
9c247bcb22
Copying the link to an attachment should make sure that it is located in the same note folder -> Fixes #1924
2018-05-29 17:20:14 +02:00
ehhc
2fce78422b
Merge branch 'master' into OnBlur_Throws_Exceptions_On_Snippet_Notes
2018-05-28 09:00:57 +02:00
ehhc
8132dd6847
Fix for the issues raised in the code review
2018-05-28 08:58:09 +02:00