Baptiste Augrain
7a5a821f8a
fix failing test
2018-10-09 00:47:37 +02:00
Baptiste Augrain
39eaed260a
display correctly attached image
2018-10-08 15:57:42 +02:00
Keyon U
2bbcb8ca89
Add comments for the “rotate fix”
2018-08-22 18:03:02 +08:00
Keyon U
48beb184df
Fix drop image rotate wrong
...
Fix drag-drop image rotate wrong, as Jordan Thornquest mentioned in slack
2018-08-22 12:23:45 +08:00
Maciek
4a3bcaba06
BUG FIX: Change the way of checking for empty array
...
The original condition : attachments !== [] always returns true,
for empty array, as well as for array with elements.
2018-07-28 22:25:10 +02:00
Maciek
1d1ab65edd
BUG FIX: snippet notes are not displaying in markdown #2088
...
Fix for issue https://github.com/BoostIo/Boostnote/issues/2088 .
In specific situation, when all below conditions are met :
- one of the snippets notes tabs is a Markdown tab,
- the migrateAttachments code is called on a snippet note,
- historical attachments location '/images' exists in snippet storage
folder
Following exception is being thrown :
path.js:28 Uncaught TypeError: Path must be a string. Received undefined
The exception is a result of an undefined noteKey variable
(which is defined only for Markdown notes).
The solution is to skip migration of attachments for notes without
noteKey (which wouldn't be possible anyway, since noteKey is a
necessary for creating folder for attachments).
2018-07-28 22:23:14 +02:00
Santiago Agüero
c37b780ca4
Use markdown content for migrateAttachments
2018-07-17 00:13:13 -03:00
Santiago Agüero
5cc52f91cb
Fix lint errors
2018-07-15 12:07:27 -03:00
Santiago Agüero
a46b9fb2be
Fix attachment interop between win and nix
2018-07-15 01:37:47 -03:00
ehhc
c69f34836a
handle dot in file name
2018-06-25 15:18:45 +02:00
ehhc
7970016fbf
One more try to fix the handling of images in the legacy location
2018-06-20 08:48:55 +02:00
ehhc
5d62dd2002
Merge branch 'master' of https://github.com/BoostIO/Boostnote into paste_storage_link_should_clone_attachment
...
# Conflicts:
# browser/main/lib/dataApi/attachmentManagement.js
# locales/da.json
# locales/de.json
# locales/en.json
# locales/es-ES.json
# locales/fa.json
# locales/fr.json
# locales/hu.json
# locales/it.json
# locales/ja.json
# locales/ko.json
# locales/no.json
# locales/pl.json
# locales/pt-BR.json
# locales/pt-PT.json
# locales/ru.json
# locales/sq.json
# locales/zh-CN.json
# locales/zh-TW.json
2018-06-06 12:03:53 +02:00
Junyoung Choi (Sai)
88856b788a
Merge pull request #1963 from ehhc/OnBlur_Throws_Exceptions_On_Snippet_Notes
...
OnBlur throws exceptions if the notetype is snippet -> Fixes #1962
2018-06-06 11:11:27 +09:00
ehhc
22e2c3da1f
Merge branch 'master' of https://github.com/BoostIO/Boostnote into paste_storage_link_should_clone_attachment
...
# Conflicts:
# browser/components/CodeEditor.js
# browser/main/lib/dataApi/attachmentManagement.js
2018-06-05 11:28:42 +02:00
ehhc
b526d48946
CodeReview
2018-06-05 11:16:50 +02:00
ehhc
ffae53326a
Fix for the issues raised in the code review
2018-06-04 11:55:23 +09:00
ehhc
ddd1522e19
Pasting an image should insert a relative attachment file link -> fixes #1953
2018-06-04 11:55:23 +09:00
ehhc
4bc0cccb24
Migrate attachments from /images to /attachments -> fix #1941
2018-06-04 11:55:23 +09:00
ehhc
9c247bcb22
Copying the link to an attachment should make sure that it is located in the same note folder -> Fixes #1924
2018-05-29 17:20:14 +02:00
ehhc
2fce78422b
Merge branch 'master' into OnBlur_Throws_Exceptions_On_Snippet_Notes
2018-05-28 09:00:57 +02:00
ehhc
8132dd6847
Fix for the issues raised in the code review
2018-05-28 08:58:09 +02:00
ehhc
2f4eb595f6
OnBlur throws exceptions if the notetype is snippet -> Fixes #1962
2018-05-23 19:47:41 +02:00
ehhc
bfcf349ffe
Attachment management should only become active on cloning notes if the note was of type MARKDOWN_NOTE -> No Stacktraces otherwise!
2018-05-23 19:24:03 +02:00
ehhc
cd6233a3d7
Cloning of a note should also clone its attachments -> works if the notes are in different storages now
2018-05-20 15:49:15 +02:00
ehhc
f76224bd17
Cloning of a note should also clone its attachments -> fixes #1904
2018-05-20 15:18:49 +02:00
ehhc
8afa373726
Attachments should be visible immediately
2018-05-20 13:55:10 +02:00
Junyoung Choi (Sai)
d3091a5384
Merge branch 'master' into Moving_Note_With_Attachment
2018-05-17 01:28:47 +09:00
ehhc
007d3e52c5
Merge branch 'master' into Issue_1900
2018-05-15 20:26:10 +02:00
ehhc
f10fa632ca
Move note with attachment to different storage Fix for #1788
2018-05-15 20:17:32 +02:00
ehhc
03fd1e29e3
Fix for the broken test
2018-05-10 22:30:13 +02:00
ehhc
73ba8b8b13
Deleting a note should also delete the attachments -> fixes #1900
2018-05-10 21:36:58 +02:00
ehhc
ffc3fb770c
Deleting of attachments -> fixes #1828 and fixes #740
2018-05-10 20:27:47 +02:00
ehhc
e9de8f42e5
Fix eslinter
2018-04-27 09:16:30 +02:00
ehhc
bf3f5a5971
Fixes #1827 -> include attachments in HTML exports of notes
2018-04-27 08:51:47 +02:00
ehhc
a76aed2d4e
Fixes #1822
2018-04-21 14:49:43 +02:00
ehhc
d2163dacf9
Fixes #1825 Refactoring of the attachment/image management
2018-04-21 14:32:24 +02:00
