Nguyễn Việt Hưng
28b8141c6b
fixed test
2019-08-30 12:46:40 +09:00
Nguyễn Việt Hưng
0b84a372f6
re-organize attachment functions and updated comments doc
2019-08-30 12:46:40 +09:00
Nguyễn Việt Hưng
8355e1e006
updated function name and return type
2019-08-30 12:46:40 +09:00
Nguyễn Việt Hưng
c7d33fbd83
Allow user to view attachments and clear unused attachments
2019-08-30 12:46:40 +09:00
Jack Hsieh
f09297f406
Fix 2636 ( #3206 )
...
* Fix 2636 Can't scroll to bottom of editor pane
* Fix minor lint issues
2019-08-11 23:22:53 +09:00
Baptiste Augrain
4e30d4b8fb
fix URLs by using the correct path separator ('/' for an url and not path.sep)
2019-07-20 00:58:51 +09:00
ehhc
cb7ac77c61
Update attachmentManagement.js
...
Deleting unneeded stupid log-message
2019-07-10 11:42:00 +09:00
ehhc
55a7ee1f91
Debounce deletion of un-referenced attachments --> don't fixes but mitigates the problems of #3103
2019-07-10 11:42:00 +09:00
milotodt
d41663143b
Repush due to pipeline issues
2019-04-15 10:43:10 +09:00
milotodt
9db363865c
Slight refactor
2019-04-15 10:43:10 +09:00
milotodt
9b03a32eec
removed uneeded line of code
2019-04-15 10:43:10 +09:00
milotodt
eeec1b12b5
adjusted handleAttachmentDrop
2019-04-15 10:43:10 +09:00
anasasilva
fba9afd6f5
Shorter code
2019-04-08 21:10:42 +09:00
anasasilva
c474d972cb
Supports relative and absolute path
2019-04-08 21:10:42 +09:00
anasasilva
3d6f670e8d
regex fixed again
2019-04-08 21:10:42 +09:00
anasasilva
9d47f319a0
absolute path
2019-04-08 21:10:42 +09:00
anasasilva
7106f042da
Regex fixed
2019-04-08 21:10:42 +09:00
anasasilva
ea6e56842f
Error message when the image path is wrong
2019-04-08 21:10:42 +09:00
anasasilva
65926fea73
fixing identation and regex
2019-04-08 21:10:42 +09:00
anasasilva
85cb94d99d
importAttachments
2019-04-08 21:10:42 +09:00
Baptiste Augrain
e0d9cf7f5c
fix dropping image from Firefox on Linux
2019-02-04 18:22:10 +01:00
Baptiste Augrain
10ea5d00eb
avoid converting SVG
2019-02-04 14:09:11 +01:00
Baptiste Augrain
de76f55fe2
fix gif
2019-02-04 13:54:45 +01:00
Baptiste Augrain
cd301d514c
Merge branch 'master' into drop-browser-image
2019-02-04 13:36:32 +01:00
Junyoung Choi
53ff693e95
Merge pull request #2852 from Aaron-Bird/bug-gif
...
[Fix] GIFs don't animate
2019-02-04 12:25:28 +09:00
Baptiste Augrain
215484c19a
add tests
2019-02-01 16:27:47 +01:00
Baptiste Augrain
851d3ba159
fix image path when the dropped image's url contains a query
2019-01-31 23:26:31 +01:00
Aaron-Bird
806139091c
fix: GIFs don't animate
2019-01-31 01:08:07 +08:00
Baptiste Augrain
a85a27f225
- fix bad regex
...
- improve test
- fix missing 'e' in some functions name
2019-01-29 16:05:30 +01:00
ehhc
7165c4550b
possibly fix for the broken test...
2019-01-26 18:16:39 +01:00
ehhc
472496d59c
possibly fix for the broken test...
2019-01-26 17:53:31 +01:00
ehhc
127da40256
possibly fix for the broken test...
2019-01-26 17:37:04 +01:00
ehhc
a113b99de0
Strange url-handling reverted + tests modified so that they might find that issue in the future + test modified so that they both contain tests for posix and windows path separator -> fixes #2834
2019-01-26 17:21:53 +01:00
Junyoung Choi
5f385e4c03
Merge pull request #2465 from daiyam/gallery
...
add image gallery
2018-12-24 17:19:03 +09:00
Baptiste Augrain
900f20f164
handle all dropped images
2018-11-28 15:58:58 +01:00
Baptiste Augrain
c2e4bae9dd
fix regex to correctly match the src attribute when there is a data-src attribute
2018-11-28 15:00:29 +01:00
Baptiste Augrain
9050035c74
- add option to enable/disable smart paste
...
- add shortcut to paste smartly
- use electron's clipboard
2018-11-28 00:44:15 +01:00
Baptiste Augrain
64f7233bfc
fix regex to match :storage reference, added comment to explain what it does.
2018-11-25 16:58:11 +01:00
Baptiste Augrain
9d81e4be2f
undo change
2018-11-25 16:17:01 +01:00
Baptiste Augrain
2908884202
drag and drop image from browser
2018-11-25 15:56:11 +01:00
Baptiste Augrain
b1a7f0fd64
Merge branch 'master' into gallery
2018-11-08 23:52:31 +01:00
Junyoung Choi (Sai)
cfc84f3e78
Merge pull request #2434 from jacobherrington/chore-remove-console-logs
...
Remove console.logs
2018-11-06 15:49:07 +09:00
Baptiste Augrain
7a5a821f8a
fix failing test
2018-10-09 00:47:37 +02:00
Baptiste Augrain
39eaed260a
display correctly attached image
2018-10-08 15:57:42 +02:00
samherrington
1246a677d1
Remove console.logs
...
Using console in production is generally undesirable due to
performance loss and security concerns. Errors were changed
to console.error and console.logs were removed.
2018-09-29 15:50:32 -05:00
Keyon U
2bbcb8ca89
Add comments for the “rotate fix”
2018-08-22 18:03:02 +08:00
Keyon U
48beb184df
Fix drop image rotate wrong
...
Fix drag-drop image rotate wrong, as Jordan Thornquest mentioned in slack
2018-08-22 12:23:45 +08:00
Maciek
4a3bcaba06
BUG FIX: Change the way of checking for empty array
...
The original condition : attachments !== [] always returns true,
for empty array, as well as for array with elements.
2018-07-28 22:25:10 +02:00
Maciek
1d1ab65edd
BUG FIX: snippet notes are not displaying in markdown #2088
...
Fix for issue https://github.com/BoostIo/Boostnote/issues/2088 .
In specific situation, when all below conditions are met :
- one of the snippets notes tabs is a Markdown tab,
- the migrateAttachments code is called on a snippet note,
- historical attachments location '/images' exists in snippet storage
folder
Following exception is being thrown :
path.js:28 Uncaught TypeError: Path must be a string. Received undefined
The exception is a result of an undefined noteKey variable
(which is defined only for Markdown notes).
The solution is to skip migration of attachments for notes without
noteKey (which wouldn't be possible anyway, since noteKey is a
necessary for creating folder for attachments).
2018-07-28 22:23:14 +02:00
Santiago Agüero
c37b780ca4
Use markdown content for migrateAttachments
2018-07-17 00:13:13 -03:00
