public/docs
1
0
Fork 0
mirror of https://github.com/sismics/docs.git synced 2026-01-03 03:49:32 +00:00
Code Issues Releases Wiki Activity

Fix error handling on DELETE /share/id

Browse Source
This commit is contained in:
jendib
2014-12-01 01:21:38 +01:00
parent 2abf0c6eab
commit 745766a2c3
2 changed files with 24 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
docs-web/src/main/java/com/sismics/docs/rest/resource/ShareResource.java
View File

@@ -91,12 +91,16 @@ public class ShareResource extends BaseResource {
// Get the share
ShareDao shareDao = new ShareDao();
DocumentDao documentDao = new DocumentDao();
Share share;
Share share = shareDao.getShare(id);
if (share == null) {
throw new ClientException("ShareNotFound", MessageFormat.format("Share not found: {0}", id));
}
// Check that the user is the owner of the linked document
try {
share = shareDao.getShare(id);
documentDao.getDocument(share.getDocumentId(), principal.getId());
} catch (NoResultException e) {
throw new ClientException("ShareNotFound", MessageFormat.format("Share not found: {0}", id));
throw new ClientException("DocumentNotFound", MessageFormat.format("Document not found: {0}", share.getDocumentId()));
}
// Delete the share