public/docs
1
0
Fork 0
mirror of https://github.com/sismics/docs.git synced 2025-12-16 03:06:22 +00:00
Code Issues Releases Wiki Activity

Fix error handling on DELETE /share/id

Browse Source
This commit is contained in:
jendib
2014-12-01 01:21:38 +01:00
parent 2abf0c6eab
commit 745766a2c3
2 changed files with 24 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
docs-web/src/test/java/com/sismics/docs/rest/TestShareResource.java
View File

@@ -109,6 +109,16 @@ public class TestShareResource extends BaseJerseyTest {
byte[] fileBytes = ByteStreams.toByteArray(is);
Assert.assertEquals(163510, fileBytes.length);
// Deletes the share (not allowed)
clientUtil.createUser("share2");
String share2AuthenticationToken = clientUtil.login("share2");
shareResource = resource().path("/share/" + share1Id);
shareResource.addFilter(new CookieAuthenticationFilter(share2AuthenticationToken));
response = shareResource.delete(ClientResponse.class);
Assert.assertEquals(Status.BAD_REQUEST, Status.fromStatusCode(response.getStatus()));
json = response.getEntity(JSONObject.class);
Assert.assertEquals("DocumentNotFound", json.getString("type"));
// Deletes the share
shareResource = resource().path("/share/" + share1Id);
shareResource.addFilter(new CookieAuthenticationFilter(share1AuthenticationToken));
@@ -117,5 +127,12 @@ public class TestShareResource extends BaseJerseyTest {
json = response.getEntity(JSONObject.class);
Assert.assertEquals("ok", json.getString("status"));
// Deletes the share again
shareResource = resource().path("/share/" + share1Id);
shareResource.addFilter(new CookieAuthenticationFilter(share1AuthenticationToken));
response = shareResource.delete(ClientResponse.class);
Assert.assertEquals(Status.BAD_REQUEST, Status.fromStatusCode(response.getStatus()));
json = response.getEntity(JSONObject.class);
Assert.assertEquals("ShareNotFound", json.getString("type"));
}
}