diff --git a/.github/workflows/check_pr_tasks_completed.yml b/.github/workflows/check_pr_tasks_completed.yml index 4eaa267..fbcc734 100644 --- a/.github/workflows/check_pr_tasks_completed.yml +++ b/.github/workflows/check_pr_tasks_completed.yml @@ -11,7 +11,7 @@ jobs: id: get-app-token uses: tibdex/github-app-token@v1 with: - app_id: 242301 + app_id: ${{ secrets.PR_TASK_COMPLETED_CHECKER_APP_ID }} private_key: ${{ secrets.PR_TASK_COMPLETED_CHECKER_APP_PRIVATE_KEY }} - uses: Shopify/task-list-checker@main diff --git a/docs/kubernetes/sealed-secrets.md b/docs/kubernetes/sealed-secrets.md index ff4d562..67f7586 100644 --- a/docs/kubernetes/sealed-secrets.md +++ b/docs/kubernetes/sealed-secrets.md @@ -428,32 +428,31 @@ Then work your way through the values you pasted, and change any which are speci ### HelmRelease -Lastly, having set the scene above, we define the HelmRelease which will actually deploy the sealed-secrets controller into the cluster, with the config we defined above. I save this in my flux repo as `sealed-secrets/helmrelease-sealed-secrets.yaml`: +Lastly, having set the scene above, we define the HelmRelease which will actually deploy the sealed-secrets controller into the cluster, with the config we defined above. I save this in my flux repo: -??? example "Example HelmRelease (click to expand)" - ```yaml - apiVersion: helm.toolkit.fluxcd.io/v2beta1 - kind: HelmRelease - metadata: - name: sealed-secrets - namespace: sealed-secrets +```yaml title="/sealed-secrets/helmrelease-sealed-secrets.yaml" +apiVersion: helm.toolkit.fluxcd.io/v2beta1 +kind: HelmRelease +metadata: + name: sealed-secrets + namespace: sealed-secrets +spec: + chart: spec: - chart: - spec: - chart: sealed-secrets - version: 1.x - sourceRef: - kind: HelmRepository - name: sealed-secrets - namespace: flux-system - interval: 15m - timeout: 5m - releaseName: sealed-secrets - valuesFrom: - - kind: ConfigMap - name: sealed-secrets-helm-chart-value-overrides - valuesKey: values.yaml # This is the default, but best to be explicit for clarity - ``` + chart: sealed-secrets + version: 1.x + sourceRef: + kind: HelmRepository + name: sealed-secrets + namespace: flux-system + interval: 15m + timeout: 5m + releaseName: sealed-secrets + valuesFrom: + - kind: ConfigMap + name: sealed-secrets-helm-chart-value-overrides + valuesKey: values.yaml # This is the default, but best to be explicit for clarity +``` --8<-- "kubernetes-why-not-config-in-helmrelease.md" diff --git a/scripts/build.sh b/scripts/build.sh index a2d8c50..f881cf9 100755 --- a/scripts/build.sh +++ b/scripts/build.sh @@ -8,14 +8,14 @@ # python3 scripts/build.py mkdocs.yml # install mkdocs (or insiders version, if we're passed a GH_TOKEN var) -if [ "$GH_TOKEN" -eq "" ] +if [ -z "$GH_TOKEN" ] then echo "No GH_TOKEN passed, doing a normal build.." pip install mkdocs-material ENABLE_PDF_EXPORT=0 mkdocs build -f mkdocs.yml else echo "GH_TOKEN passed, doing an insiders build.." - pip install -e mkdocs-material-insiders + pip install git+https://${GH_TOKEN}@github.com/squidfunk/mkdocs-material-insiders.git ENABLE_PDF_EXPORT=0 mkdocs build -f mkdocs-insiders.yml fi