From fe707046674c245115ed2681c021de3cb2ff5c07 Mon Sep 17 00:00:00 2001 From: David Young Date: Thu, 14 Jan 2021 11:55:56 +1300 Subject: [PATCH] GitHub housekeeping (workflows and templates) --- .github/CODEOWNERS | 3 ++ .github/PULL_REQUEST_TEMPLATE/Bug_report.md | 44 ------------------ .../PULL_REQUEST_TEMPLATE/Feature_request.md | 23 ---------- .../PULL_REQUEST_TEMPLATE/Regression-v7.md | 45 ------------------- .../PULL_REQUEST_TEMPLATE/Support_question.md | 19 -------- .github/PULL_REQUEST_TEMPLATE/Support_us.md | 28 ------------ .github/PULL_REQUEST_TEMPLATE/config.yml | 8 ---- .github/pull_request_template.md | 3 +- .github/workflows/pr-checklist-completed.yml | 12 +++++ 9 files changed, 17 insertions(+), 168 deletions(-) create mode 100644 .github/CODEOWNERS delete mode 100644 .github/PULL_REQUEST_TEMPLATE/Bug_report.md delete mode 100644 .github/PULL_REQUEST_TEMPLATE/Feature_request.md delete mode 100644 .github/PULL_REQUEST_TEMPLATE/Regression-v7.md delete mode 100644 .github/PULL_REQUEST_TEMPLATE/Support_question.md delete mode 100644 .github/PULL_REQUEST_TEMPLATE/Support_us.md delete mode 100644 .github/PULL_REQUEST_TEMPLATE/config.yml create mode 100644 .github/workflows/pr-checklist-completed.yml diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 0000000..3127bc6 --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,3 @@ +# Unless more-specific rules are added, all PRs require @funkypenguin's approval ;) + +* @funkypenguin diff --git a/.github/PULL_REQUEST_TEMPLATE/Bug_report.md b/.github/PULL_REQUEST_TEMPLATE/Bug_report.md deleted file mode 100644 index 344922e..0000000 --- a/.github/PULL_REQUEST_TEMPLATE/Bug_report.md +++ /dev/null @@ -1,44 +0,0 @@ ---- -name: "\U0001F41B Bug Report" -about: "If something isn't working as expected \U0001F914." -title: '' -labels: 'i: bug, i: needs triage' -assignees: '' - ---- - -## Bug Report - -**Current Behavior** -A clear and concise description of the behavior. - -**Input Code** -- REPL or Repo link if applicable: - -```js -var your => (code) => here; -``` - -**Expected behavior/code** -A clear and concise description of what you expected to happen (or code). - -**Babel Configuration (.babelrc, package.json, cli command)** - -```js -{ - "your": { "config": "here" } -} -``` - -**Environment** -- Babel version(s): [e.g. v6.0.0, v7.0.0-beta.34] -- Node/npm version: [e.g. Node 8/npm 5] -- OS: [e.g. OSX 10.13.4, Windows 10] -- Monorepo: [e.g. yes/no/Lerna] -- How you are using Babel: [e.g. `cli`, `register`, `loader`] - -**Possible Solution** - - -**Additional context/Screenshots** -Add any other context about the problem here. If applicable, add screenshots to help explain. diff --git a/.github/PULL_REQUEST_TEMPLATE/Feature_request.md b/.github/PULL_REQUEST_TEMPLATE/Feature_request.md deleted file mode 100644 index b9c8254..0000000 --- a/.github/PULL_REQUEST_TEMPLATE/Feature_request.md +++ /dev/null @@ -1,23 +0,0 @@ ---- -name: "\U0001F680 Feature Request" -about: "I have a suggestion (and may want to implement it \U0001F642)!" -title: '' -labels: 'i: enhancement, i: needs triage' -assignees: '' - ---- - -## Feature Request - -**Is your feature request related to a problem? Please describe.** -A clear and concise description of what the problem is. Ex. I have an issue when [...] - -**Describe the solution you'd like** -A clear and concise description of what you want to happen. Add any considered drawbacks. - -**Describe alternatives you've considered** -A clear and concise description of any alternative solutions or features you've considered. - -**Teachability, Documentation, Adoption, Migration Strategy** -If you can, explain how users will be able to use this and possibly write out a version the docs. -Maybe a screenshot or design? diff --git a/.github/PULL_REQUEST_TEMPLATE/Regression-v7.md b/.github/PULL_REQUEST_TEMPLATE/Regression-v7.md deleted file mode 100644 index a700b90..0000000 --- a/.github/PULL_REQUEST_TEMPLATE/Regression-v7.md +++ /dev/null @@ -1,45 +0,0 @@ ---- -name: "\U0001F4A5 v7 Regression" -about: Report an unexpected behavior in v7 from v6 (Check the upgrade guide first - ✌️) -title: '' -labels: 'i: bug, 7.x: regression, i: needs triage' -assignees: '' - ---- - -# v7 Regression - -> First check out: https://babeljs.io/docs/en/v7-migration -> Also a partial upgrade tool: https://github.com/babel/babel-upgrade - -**Potential Commit/PR that introduced the regression** -If you have time to investigate, what PR/date introduced this issue. - -**Describe the regression** -A clear and concise description of what the regression is. - -**Input Code** - - -```js -var your => (code) => here; -``` - -**Babel Configuration (.babelrc, package.json, cli command)** - -```js -{ - "your": { "config": "here" } -} -``` - -**Expected behavior/code** -A clear and concise description of what you expected to happen (or code). - -**Environment** -- Babel version(s): [e.g. v6.0.0, v7.0.0-beta.34] -- Node/npm version: [e.g. Node 8/npm 5] -- OS: [e.g. OSX 10.13.4, Windows 10] -- Monorepo [e.g. yes/no/Lerna] -- How you are using Babel: [e.g. `cli`, `register`, `loader`] diff --git a/.github/PULL_REQUEST_TEMPLATE/Support_question.md b/.github/PULL_REQUEST_TEMPLATE/Support_question.md deleted file mode 100644 index 57c183f..0000000 --- a/.github/PULL_REQUEST_TEMPLATE/Support_question.md +++ /dev/null @@ -1,19 +0,0 @@ ---- -name: "\U0001F917 Support Question" -about: "If you have a question \U0001F4AC, please check out our Slack or StackOverflow!" -title: '' -labels: 'i: question, i: needs triage' -assignees: '' - ---- - ---------------^ Click "Preview" for a nicer view! -We primarily use GitHub as an issue tracker; for usage and support questions, please check out these resources below. Thanks! 😁. - ---- - -* Slack Community Chat: https://babeljs.slack.com (you can sign-up at https://slack.babeljs.io/ for an invite) -* StackOverflow: https://stackoverflow.com/questions/tagged/babeljs using the tag `babeljs` -* Twitter: If it's just a quick question you can ping our Twitter: https://twitter.com/babeljs -* Also have a look at the readme for more information on how to get support: - https://github.com/babel/babel/blob/master/README.md diff --git a/.github/PULL_REQUEST_TEMPLATE/Support_us.md b/.github/PULL_REQUEST_TEMPLATE/Support_us.md deleted file mode 100644 index cd7eb39..0000000 --- a/.github/PULL_REQUEST_TEMPLATE/Support_us.md +++ /dev/null @@ -1,28 +0,0 @@ ---- -name: "\U0001F91D Support us on Babel" -about: "If you would like to support our efforts in maintaining this community-driven - project \U0001F64C!" -title: '' -labels: '' -assignees: '' - ---- - ---------------^ Click "Preview" for a nicer view! -> Open Collective: https://opencollective.com/babel -> Henry's Patreon: https://www.patreon.com/henryzhu - -Help support Babel! - -Babel has always been a community project, not really backed or owned by any single (or group) of companies. While some maintainers used to work at Facebook (and Henry at Adobe) no one was working on it full time and there certainly isn't a huge company or team anywhere doing all this work. - ---- - -As a group of volunteers you can help us in a few ways - -- Giving developer time on the project. (Message us on [Twitter](https://twitter.com/babeljs) or [Slack](https://slack.babeljs.io/) for guidance). Companies should be paying their employees to contribute back to the open source projects they use everyday. -- Giving funds by becoming one of our sponsors/donators! - -If you'd like to sustain the future of the project as a whole, we have an [Open Collective](https://opencollective.com/babel) that you can donate to. This is a way for funds to be allocated to the core team. - -You can also support [Henry](https://github.com/hzoo) directly since I [left my job to work on Babel and Open Source full time](https://twitter.com/left_pad/status/969793227862790144) at my [Patreon](https://www.patreon.com/henryzhu). diff --git a/.github/PULL_REQUEST_TEMPLATE/config.yml b/.github/PULL_REQUEST_TEMPLATE/config.yml deleted file mode 100644 index fe06231..0000000 --- a/.github/PULL_REQUEST_TEMPLATE/config.yml +++ /dev/null @@ -1,8 +0,0 @@ -blank_issues_enabled: false -contact_links: - - name: Discord Server - url: http://chat.funkypenguin.co.nz/ - about: For real-time, short-lived help - - name: Discourse Forums - url: https://discourse.geek-kitchen.funkypenguin.co.nz/ - about: For asyncronous, long-lived discussions \ No newline at end of file diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 87d5d66..c9f32a5 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -32,4 +32,5 @@ delete these next checks if not adding a new recipe - [ ] I've updated `CHANGELOG.md` in reverse chronological order order - [ ] I'm using the [oldest-possible version](https://docs.docker.com/compose/compose-file/compose-versioning/#version-3) of Docker-compose syntax for the feature my recipe needs - [ ] If traefik integration is required, I've included both v1 and v2 labels (*see [template](/manuscript/recipes/template.md)*) -- [ ] If a recipe-specific overlay network is required, I've used a unique subnet and recorded it in [networks.md](manuscript/reference/networks.md) \ No newline at end of file +- [ ] If a recipe-specific overlay network is required, I've used a unique subnet and recorded it in [networks.md](manuscript/reference/networks.md) +- [ ] I've considered updating `.github/CODEOWNERS` so that I'll be automatically included as a reviewer on future changes to this recipe \ No newline at end of file diff --git a/.github/workflows/pr-checklist-completed.yml b/.github/workflows/pr-checklist-completed.yml new file mode 100644 index 0000000..8eb488a --- /dev/null +++ b/.github/workflows/pr-checklist-completed.yml @@ -0,0 +1,12 @@ +name: 'PR Tasks Completed Check' +on: + pull_request: + types: [opened, edited] + +jobs: + task-check: + runs-on: ubuntu-latest + steps: + - uses: kentaro-m/task-completed-checker-action@v0.1.0 + with: + repo-token: "${{ secrets.GITHUB_TOKEN }}" \ No newline at end of file