From 275028b082f2218af80310489ad432d4ced150e9 Mon Sep 17 00:00:00 2001 From: Yusuf Yilmaz Date: Thu, 12 Jan 2023 11:52:49 +0100 Subject: [PATCH] Add pull request template --- .github/pull_request_template.md | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 0000000..e7aba72 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,32 @@ +[ABC-1234](https://toptal-core.atlassian.net/browse/ABC-1234) + +### Description + +Describe the changes and motivations for the pull request, unless obvious from the title. + +[Designs](https://share.abstract.com) (if applicable) + +### How to test + +- `yarn` +- FIXME: Add the steps describing how to test your changes manually + +### Environment variables + +Include a snapshot of the ENV vars used in your local env when this PR was created. +``` +PUBLIC_ENV_VAR=public-value +GLOBAL_SECRET_ENV_VAR=xxx # Added in 1Password in Shared-Utilities-Environment group +OWN_PRIVATE_ENV_VAR # Different for everyone +``` + +### Acceptance Criteria + +- [ ] Add acceptance criterias from Jira task [ABC-1234] + +### Pre-merge checklist + +- [ ] The PR relates to a single subject with a clear title and description in grammatically correct, complete sentences. +- [ ] Verify that feature branch is up-to-date with `master` (if not - rebase it). +- [ ] Double check the quality of [commit messages](http://chris.beams.io/posts/git-commit/). +- [ ] A snapshot of the author's env vars has been added