From e7bdd20ab54a073616dab12ce9905a194721c152 Mon Sep 17 00:00:00 2001 From: Yusuf Yilmaz Date: Mon, 16 Jan 2023 14:37:34 +0100 Subject: [PATCH] Fix pr template --- .github/pull_request_template.md | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 098bc50..1db011e 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -8,15 +8,17 @@ Describe the changes and motivations for the pull request, unless obvious from t ### How to test -- `yarn` +- `bundle install` - FIXME: Add the steps describing how to test your changes manually ### Environment variables -You should add the following to your ~.bash_profile: +Include a snapshot of the ENV vars used in your local env when this PR was created. -```bash -export ENV_VAR="value" +``` +PUBLIC_ENV_VAR=public-value +GLOBAL_SECRET_ENV_VAR=xxx # Added in 1Password in Shared-Utilities-Environment group +OWN_PRIVATE_ENV_VAR # Different for everyone ``` ### Acceptance Criteria