Tests and major refactor

[#16]

.gitignore

@@ -1,3 +1,5 @@
 *.swp
 *.swo
 *.gem
+Gemfile.lock
+.rspec

Gemfile

@@ -0,0 +1,2 @@
+source 'https://rubygems.org'
+gemspec

README.md

@@ -13,6 +13,20 @@ This can be really really cool in combination with `pbcopy`, like:
 
 after which the contents of `file` will be accessible at a URL which has been copied to your pasteboard.
 
+## Installation
+
+``` bash
+gem install haste
+```
+
+## Support
+
+Please consider paying what you think haste-client is worth:
+
+<a href="https://www.stripeme.com/pay/1r2f">
+  <img alt="Pay" src="https://www.stripeme.com/pay.jpg" />
+</a>
+
 ## Making uploading file contents easier
 
 If you supply a valid file path as argument #1 to the client, it will be uploaded:
@@ -33,10 +47,33 @@ alias work_haste="HASTE_SERVER=http://something.com haste"
 
 After which you can use `work_haste` to send hastes to that server instead.
 
+## Use as a library
+
+You can also use `Haste` as a library to upload hastes:
+
+``` ruby
+uploader = Haste::Uploader.new
+uploader.upload_raw 'this is my data' # key
+```
+
 ## Windows Support
 
 If you'd like an alternative on Windows that supports functionality similar to `pbcopy`, check out Aidan Ryan's [WinHaste](https://github.com/ajryan/WinHaste) project.
 
+## Lightweight Alternative
+
+Han Boetes has contributed a simple shell-script alternative for those not interested in installing a RubyGem:
+
+``` bash
+haste(){ ( echo "% $@"; eval "$@" ) | curl -F "$@=<-" http://hastebin.com/documents|awk -F '"' '{print "http://hastebin.com/"$4}'}
+```
+
+Usage:
+
+``` bash
+haste `cat index.html
+```
+
 ## Author
 
 John Crepezzi <john.crepezzi@gmail.com>

Rakefile

@@ -1,7 +1,6 @@
-require 'rspec/core/rake_task'
 require File.dirname(__FILE__) + '/lib/haste/version'
- 
+
-task :build => :test do
+task :build do
   system "gem build haste.gemspec"
 end
 
@@ -12,14 +11,3 @@ task :release => :build do
   # push the gem
   system "gem push haste-#{Haste::VERSION}.gem"
 end
- 
-RSpec::Core::RakeTask.new(:test) do |t|
-  t.pattern = 'spec/**/*_spec.rb'
-  fail_on_error = true # be explicit
-end
- 
-RSpec::Core::RakeTask.new(:rcov) do |t|
-  t.pattern = 'spec/**/*_spec.rb'
-  t.rcov = true
-  fail_on_error = true # be explicit
-end

haste.gemspec

@@ -6,6 +6,7 @@ spec = Gem::Specification.new do |s|
   s.author = 'John Crepezzi'
   s.add_development_dependency('rspec')
   s.add_dependency('json')
+  s.add_dependency('rest-client')
   s.description = 'CLI Haste Client'
   s.email = 'john.crepezzi@gmail.com'
   s.executables = 'haste'

lib/haste.rb

@@ -1,53 +1,10 @@
+require 'bundler/setup'
 require 'json'
-require 'net/http'
 require 'uri'
+require 'rest-client'
+require File.dirname(__FILE__) + '/haste/uploader'
+require File.dirname(__FILE__) + '/haste/exception'
+require File.dirname(__FILE__) + '/haste/cli'
 
 module Haste
-
-  DEFAULT_URL = 'http://hastebin.com'
-
-  class CLI
-
-    # Pull all of the data from STDIN
-    def initialize
-      if STDIN.tty?
-        abort 'No input file given' unless ARGV.length == 1
-        abort "#{file}: No such path" unless File.exists?(file = ARGV[0])
-        @input = open(file).read
-      else
-        @input = STDIN.readlines.join
-      end
-      # clean up
-      @input.strip!
-    end
-
-    # Upload the and output the URL we get back
-    def start
-      uri = URI.parse server
-      http = Net::HTTP.new uri.host, uri.port
-      response = http.post '/documents', @input
-      if response.is_a?(Net::HTTPOK)
-        data = JSON.parse(response.body)
-        method = STDOUT.tty? ? :puts : :print
-        STDOUT.send method, "#{server}/#{data['key']}"
-      else
-        abort "failure uploading: #{response.code}"
-      end
-    rescue JSON::ParserError => e
-      abort "failure uploading: #{response.code}"
-    rescue Errno::ECONNREFUSED => e
-      abort "failure connecting: #{e.message}"
-    end
-
-    private
-
-    def server
-      return @server if @server
-      @server = (ENV['HASTE_SERVER'] || Haste::DEFAULT_URL).dup
-      @server.chop! if server.end_with?('/')
-      @server
-    end
-
-  end
-
 end

lib/haste/cli.rb

@@ -0,0 +1,31 @@
+module Haste
+
+  class CLI
+
+    # Create a new uploader
+    def initialize
+      @uploader = Uploader.new ENV['HASTE_SERVER']
+    end
+
+    # And then handle the basic usage
+    def start
+      # Take data in
+      key = if STDIN.tty?
+        @uploader.upload_path ARGV.first
+      else
+        @uploader.upload_raw STDIN.readlines.join
+      end
+      # And write data out
+      url = "#{@uploader.server_url}/#{key}"
+      if STDOUT.tty?
+        STDOUT.puts url
+      else
+        STDOUT.print url
+      end
+    rescue Exception => e
+      abort e.message
+    end
+
+  end
+
+end

lib/haste/exception.rb

@@ -0,0 +1,4 @@
+module Haste
+  class Exception < StandardError
+  end
+end

lib/haste/uploader.rb

@@ -0,0 +1,44 @@
+module Haste
+
+  DEFAULT_URL = 'http://hastebin.com'
+
+  class Uploader
+
+    attr_reader :server_url
+
+    def initialize(server_url = nil)
+      @server_url = server_url || Haste::DEFAULT_URL
+      @server_url = @server_url.dup
+      @server_url = @server_url.chop if @server_url.end_with?('/')
+    end
+
+    # Take in a path and return a key
+    def upload_path(path)
+      fail_with 'No input file given' unless path
+      fail_with "#{path}: No such path" unless File.exists?(path)
+      upload_raw open(path).read
+    end
+
+    # Take in data and return a key
+    def upload_raw(data)
+      data.rstrip!
+      raw_data = RestClient.post "#{self.server_url}/documents", data
+      data = JSON.parse(raw_data)
+      data['key']
+    rescue JSON::ParserError => e
+      fail_with "failure parsing response: #{e.message}"
+    rescue RestClient::Exception => e
+      fail_with "failure uploading: #{e.message}"
+    rescue Errno::ECONNREFUSED => e
+      fail_with "failure connecting: #{e.message}"
+    end
+
+    private
+
+    def fail_with(msg)
+      raise Exception.new(msg)
+    end
+
+  end
+
+end

lib/haste/version.rb

@@ -1,5 +1,5 @@
 module Haste
 
-  VERSION = '0.1.3'
+  VERSION = '0.1.7'
 
 end

spec/examples/uploader_spec.rb

@@ -0,0 +1,173 @@
+require 'spec_helper'
+
+describe Haste::Uploader do
+
+  let(:uploader) { base.nil? ? Haste::Uploader.new : Haste::Uploader.new(base) }
+
+  describe :upload_raw do
+
+    let(:data) { 'hello world' }
+    let(:url) { "#{uploader.server_url}/documents" }
+    let(:base) { nil }
+    let(:error_message) do
+      begin
+        @key = uploader.upload_raw data
+        nil # nil otherwise
+      rescue Haste::Exception => e
+        e.message
+      end
+    end
+
+    context 'with a good response' do
+
+      let(:json) { '{"key":"hello"}' }
+
+      before do
+        RestClient.should_receive(:post).with(url, data).and_return(json)
+      end
+
+      it 'should get the key' do
+        error_message.should be_nil # no error
+        @key.should == 'hello'
+      end
+
+    end
+
+    context 'with a bad json response' do
+
+      let(:json) { '{that:not_even_json}' }
+
+      before do
+        RestClient.should_receive(:post).with(url, data).and_return(json)
+      end
+
+      it 'should get an error' do
+        error_message.should start_with 'failure parsing response: '
+      end
+
+    end
+
+    context 'with a 404 response' do
+
+      before do
+        error = RestClient::ResourceNotFound.new
+        RestClient.should_receive(:post).with(url, data).and_raise(error)
+      end
+
+      it 'should get an error' do
+        error_message.should == 'failure uploading: Resource Not Found'
+      end
+
+    end
+
+    context 'with a non-existent server' do
+
+      before do
+        error = Errno::ECONNREFUSED
+        RestClient.should_receive(:post).with(url, data).and_raise(error)
+      end
+
+      it 'should get the key' do
+        error_message.should == 'failure connecting: Connection refused'
+      end
+
+    end
+
+  end
+
+  describe :upload_path do
+
+    let(:base) { nil }
+    let(:error_message) do
+      begin
+        uploader.upload_path path
+        nil # nil otherwise
+      rescue Haste::Exception => e
+        e.message
+      end
+    end
+
+    context 'with no path given' do
+
+      let(:path) { nil }
+
+      it 'should have an error' do
+        error_message.should == 'No input file given'
+      end
+
+    end
+
+    context 'with an invalid path given' do
+
+      let(:path) { '/tmp/why-do-you-have-a-file-called-john' }
+
+      it 'should have an error' do
+        error_message.should == "#{path}: No such path"
+      end
+
+    end
+
+    context 'with a valid path' do
+
+      let(:data) { 'hello world' }
+      let(:path) { '/tmp/real' }
+      before { File.write(path, data) }
+
+      before do
+        uploader.should_receive(:upload_raw).with(data) # check
+      end
+
+      it 'should not receive an error' do
+        error_message.should be_nil
+      end
+
+    end
+
+  end
+
+  describe :server_url do
+
+    let(:server_url) { uploader.server_url }
+
+    context 'with default constructor' do
+
+      let(:base) { nil }
+
+      it 'should use the default url' do
+        server_url.should == Haste::DEFAULT_URL
+      end
+
+    end
+
+    context 'with server url passed in constructor' do
+
+      context 'with a trailing slash' do
+
+        before { @string = 'hello/' }
+        let(:base) { @string }
+
+        it 'should remove the slash' do
+          server_url.should == @string.chop
+        end
+
+        it 'should not modify the original' do
+          @string.should == 'hello/'
+        end
+
+      end
+
+      context 'with no trailing slash' do
+
+        let(:base) { 'hello' }
+
+        it 'should not chop the url' do
+          server_url.should == base
+        end
+
+      end
+
+    end
+
+  end
+
+end

spec/spec_helper.rb

@@ -0,0 +1 @@
+require File.dirname(__FILE__) + '/../lib/haste'