From 207aa872539ad7fd9b9650d1269e437cedbec2af Mon Sep 17 00:00:00 2001 From: Scott Tolksdorf Date: Wed, 6 Apr 2016 11:31:11 -0400 Subject: [PATCH] Made the page contianer update state based on page index rather than scroll valuable, should greatly reduce re-renders. --- client/homebrew/pageContainer/pageContainer.jsx | 12 ++++-------- package.json | 2 +- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/client/homebrew/pageContainer/pageContainer.jsx b/client/homebrew/pageContainer/pageContainer.jsx index 8ff5df7..123105d 100644 --- a/client/homebrew/pageContainer/pageContainer.jsx +++ b/client/homebrew/pageContainer/pageContainer.jsx @@ -14,28 +14,24 @@ var PageContainer = React.createClass({ }, getInitialState: function() { return { - scrollPosition: 0 + viewablePageIndex: 0 }; }, handleScroll : function(e){ this.setState({ - scrollPosition : e.target.scrollTop + viewablePageIndex : Math.floor(e.target.scrollTop / PAGE_HEIGHT) }); }, - getViewablePageIndex : function(){ - return Math.floor(this.state.scrollPosition / PAGE_HEIGHT); - }, - renderDummyPage : function(key){ return
- yo dawg +
}, renderPages : function(){ - var currentIndex = this.getViewablePageIndex(); + var currentIndex = this.state.viewablePageIndex; return _.map(this.props.text.split('\\page'), (pageText, index) => { if(currentIndex - 1 == index || currentIndex == index || currentIndex + 1 == index){ return
diff --git a/package.json b/package.json index dc24b07..d6168a1 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "naturalCrit", "description": "A super rad project!", - "version": "1.4.0", + "version": "1.4.1", "scripts": { "postinstall": "gulp prod", "start": "node server.js"