From f6b058f3c960d9fdfd1c02d32b3a202fbc6b65ba Mon Sep 17 00:00:00 2001 From: Rae Che Date: Mon, 20 Aug 2018 17:20:13 +0100 Subject: [PATCH] brewRenderer: Capture event properties while still in event loop. React [pools events](https://github.com/facebook/react/issues/2850), which means that once the lambda runs later on the properties we want to read will be null. Instead, we capture the properties in the event loop. --- client/homebrew/brewRenderer/brewRenderer.jsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/client/homebrew/brewRenderer/brewRenderer.jsx b/client/homebrew/brewRenderer/brewRenderer.jsx index 2f2d964..2729b6a 100644 --- a/client/homebrew/brewRenderer/brewRenderer.jsx +++ b/client/homebrew/brewRenderer/brewRenderer.jsx @@ -58,8 +58,9 @@ const BrewRenderer = createClass({ }, handleScroll : function(e){ + let target = e.target; this.setState((prevState)=>({ - viewablePageNumber : Math.floor(e.target.scrollTop / e.target.scrollHeight * prevState.pages.length) + viewablePageNumber : Math.floor(target.scrollTop / target.scrollHeight * prevState.pages.length) })); },