From 1bd2073c809ba277831e990cc93845af967a3fed Mon Sep 17 00:00:00 2001
From: jaroslawjanas <jaroslawjanas.dev@gmail.com>
Date: Thu, 11 Dec 2025 21:45:10 +0100
Subject: [PATCH] Fix volume input validation in bulk metadata editor

* Handle invalid range formats like "1-2-3" or "--" that previously fell through, now returns an error message

* Add explicit check for empty/malformed range parts before attempting to parse

* Add positive number validation for all input types (range, comma-list, single number) to be consistent with single file mode which uses isnumeric()

* Add explicit validation for empty volumes list after parsing
---
 kindlecomicconverter/KCC_gui.py | 30 +++++++++++++++++++-----------
 1 file changed, 19 insertions(+), 11 deletions(-)

diff --git a/kindlecomicconverter/KCC_gui.py b/kindlecomicconverter/KCC_gui.py
index 51fc97a..ff89800 100644
--- a/kindlecomicconverter/KCC_gui.py
+++ b/kindlecomicconverter/KCC_gui.py
@@ -1599,32 +1599,40 @@ class KCCGUI_MetaEditor(KCC_ui_editor.Ui_editorDialog):
         # Check if it's a range (e.g., "5-10")
         if '-' in text and ',' not in text:
             parts = text.split('-')
-            if len(parts) == 2:
-                try:
-                    start = int(parts[0].strip())
-                    end = int(parts[1].strip())
-                    if start <= end:
-                        volumes = list(range(start, end + 1))
-                    else:
-                        return None, 'Invalid range: start > end'
-                except ValueError:
-                    return None, 'Invalid range format'
+            if len(parts) != 2 or not parts[0].strip() or not parts[1].strip():
+                return None, 'Invalid range format (use start-end)'
+            try:
+                start = int(parts[0].strip())
+                end = int(parts[1].strip())
+                if start < 0 or end < 0:
+                    return None, 'Volume numbers must be positive'
+                if start > end:
+                    return None, 'Invalid range: start > end'
+                volumes = list(range(start, end + 1))
+            except ValueError:
+                return None, 'Invalid range format'
         # Check if it's a comma-separated list (e.g., "1,3,5")
         elif ',' in text:
             try:
                 volumes = [int(v.strip()) for v in text.split(',') if v.strip()]
+                if any(v < 0 for v in volumes):
+                    return None, 'Volume numbers must be positive'
             except ValueError:
                 return None, 'Invalid list format'
         # Single number - generate sequence starting from that number
         else:
             try:
                 start = int(text)
+                if start < 0:
+                    return None, 'Volume number must be positive'
                 volumes = list(range(start, start + fileCount))
             except ValueError:
                 return None, 'Invalid number'
         
         # Validate count
-        if volumes and len(volumes) != fileCount:
+        if not volumes:
+            return None, 'No valid volume numbers parsed'
+        if len(volumes) != fileCount:
             return None, f'Volume count ({len(volumes)}) ≠ file count ({fileCount})'
         
         return volumes, None