From 619017f031cf8985e118521a2363ea96648be78a Mon Sep 17 00:00:00 2001 From: Alex Xu Date: Wed, 21 Oct 2026 09:52:41 -0700 Subject: [PATCH] use latest node 24 when building macos (#1471) * update macos node * node>=24.22.1 * use latest node for macos --- .github/workflows/package-macos.yml | 3 ++- .github/workflows/package-osx-legacy.yml | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/package-macos.yml b/.github/workflows/package-macos.yml index 3dffc12c..942611dd 100644 --- a/.github/workflows/package-macos.yml +++ b/.github/workflows/package-macos.yml @@ -73,7 +73,8 @@ jobs: cp $PP_PATH ~/Library/MobileDevice/Provisioning\ Profiles - uses: actions/setup-node@v7 with: - node-version: 16 + node-version: 24 + check-latest: true - run: npm install -g appdmg - name: build binary # TODO /usr/bin/codesign --force -s "$MACOS_CERTIFICATE_NAME" --options runtime dist/Applications/Kindle\ Comic\ Converter.app -v diff --git a/.github/workflows/package-osx-legacy.yml b/.github/workflows/package-osx-legacy.yml index 6cc1b837..f0307c3f 100644 --- a/.github/workflows/package-osx-legacy.yml +++ b/.github/workflows/package-osx-legacy.yml @@ -45,7 +45,8 @@ jobs: ./gen_ui_files.sh - uses: actions/setup-node@v7 with: - node-version: 16 + node-version: 24 + check-latest: true - run: npm install -g appdmg - name: build binary run: |