From 61a4e44921f5a321273ffc9493825d6f1eb08753 Mon Sep 17 00:00:00 2001 From: jaroslawjanas Date: Fri, 12 Dec 2025 01:29:55 +0100 Subject: [PATCH] Fix CBR read-only check in bulk metadata editor * Check all files for CBR format during load instead of during save * Unify the CBR check for single and bulk mode --- kindlecomicconverter/KCC_gui.py | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/kindlecomicconverter/KCC_gui.py b/kindlecomicconverter/KCC_gui.py index cc01bc9..54616da 100644 --- a/kindlecomicconverter/KCC_gui.py +++ b/kindlecomicconverter/KCC_gui.py @@ -1440,6 +1440,15 @@ class KCCGUI_MetaEditor(KCC_ui_editor.Ui_editorDialog): # Sort files by name for consistent volume assignment self.files.sort() + # Unified CBR check for all files (both single and bulk mode) + for file in self.files: + parser = metadata.MetadataParser(file) + if parser.format in ['RAR', 'RAR5']: + self.editorWidget.setEnabled(False) + self.okButton.setEnabled(False) + self.statusLabel.setText('CBR files in selection are read-only.') + return + if self.bulkMode: firstFile = self.files[0] self.parser = metadata.MetadataParser(firstFile) @@ -1477,14 +1486,9 @@ class KCCGUI_MetaEditor(KCC_ui_editor.Ui_editorDialog): field.setEnabled(True) field.setPlaceholderText('') - if self.parser.format in ['RAR', 'RAR5']: - self.editorWidget.setEnabled(False) - self.okButton.setEnabled(False) - self.statusLabel.setText('CBR metadata are read-only.') - else: - self.editorWidget.setEnabled(True) - self.okButton.setEnabled(True) - self.statusLabel.setText('Separate authors with a comma.') + self.editorWidget.setEnabled(True) + self.okButton.setEnabled(True) + self.statusLabel.setText('Separate authors with a comma.') for field in (self.seriesLine, self.volumeLine, self.numberLine, self.titleLine): field.setText(self.parser.data[field.objectName().capitalize()[:-4]])