public/kcc
1
0
Fork 0
mirror of https://github.com/ciromattia/kcc synced 2026-07-04 12:05:34 +00:00
Code Issues Releases Wiki Activity

fix: enable unrar on all distros, not just Fedora (#1376)

Browse Source 
* fix: enable unrar on all distros, not just Fedora

unrar was gated behind distro.id() == 'fedora', so on Debian/Ubuntu
the binary was installed but never invoked. Try unrar unconditionally
after 7z, with an optional rarfile Python fallback.

Fixes CBR extraction on non-Fedora Linux distributions.

* fix: gate unrar on Linux and drop unused distro dependency

Debian/Ubuntu's '7zip' package ships the upstream 7zz binary, which
excludes RAR support for licensing reasons, so 7z fails to read .cbr
(RAR) archives. unrar was installed but only invoked when
distro.id() == 'fedora', so on Debian it was never tried and extraction
failed.

Per maintainer feedback, gate unrar on platform.system() == 'Linux'
(not needed on Windows or macOS) and drop the rarfile PyPI fallback to
avoid a new dependency. Since the code no longer imports distro, also
remove it from the requirements files and setup.py.
This commit is contained in:
Nils Leo
2026-07-03 00:07:36 +02:00
committed by GitHub
parent 544e866b51
commit 72e1546c2c
6 changed files with 6 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
requirements.txt
-1
View File
@@ -6,6 +6,5 @@ python-slugify>=8.0.4,<9.0.0
packaging>=26.2
mozjpeg-lossless-optimization>=1.2.0
natsort>=8.4.0
distro>=1.9.0
numpy>=1.22.4
PyMuPDF>=1.18.0