From e40cf29aa3447d5136ceb9b218c17793fef476a8 Mon Sep 17 00:00:00 2001 From: Alex Xu Date: Wed, 26 Mar 2025 13:47:16 -0700 Subject: [PATCH] don't attempt to sign on forks (#881) * overwrite unsigned binary * only sign on ciromattia * Update package-windows.yml * only sign on ciromattia --- .github/workflows/package-windows-with-docker.yml | 5 +++-- .github/workflows/package-windows.yml | 6 +++--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/package-windows-with-docker.yml b/.github/workflows/package-windows-with-docker.yml index 080a38a..c26f62d 100644 --- a/.github/workflows/package-windows-with-docker.yml +++ b/.github/workflows/package-windows-with-docker.yml @@ -50,6 +50,7 @@ jobs: - id: optional_step_id uses: signpath/github-action-submit-signing-request@v1.1 + if: ${{ github.repository == 'ciromattia/kcc' }} with: api-token: '${{ secrets.SIGNPATH_API_TOKEN }}' organization-id: '1dc1bad6-4a8c-4f85-af30-5c5d3d392ea6' @@ -57,7 +58,7 @@ jobs: signing-policy-slug: 'release-signing' github-artifact-id: '${{ steps.upload-unsigned-artifact.outputs.artifact-id }}' wait-for-completion: true - output-artifact-directory: 'dist/windows/signed/' + output-artifact-directory: 'dist/windows/' - name: Release uses: softprops/action-gh-release@v2 @@ -67,4 +68,4 @@ jobs: generate_release_notes: true files: | LICENSE.txt - dist/windows/signed/*.exe + dist/windows/*.exe diff --git a/.github/workflows/package-windows.yml b/.github/workflows/package-windows.yml index 70a8e08..dd55588 100644 --- a/.github/workflows/package-windows.yml +++ b/.github/workflows/package-windows.yml @@ -49,6 +49,7 @@ jobs: path: dist/*.exe - id: optional_step_id uses: signpath/github-action-submit-signing-request@v1.1 + if: ${{ github.repository == 'ciromattia/kcc' }} with: api-token: '${{ secrets.SIGNPATH_API_TOKEN }}' organization-id: '1dc1bad6-4a8c-4f85-af30-5c5d3d392ea6' @@ -56,7 +57,7 @@ jobs: signing-policy-slug: 'release-signing' github-artifact-id: '${{ steps.upload-unsigned-artifact.outputs.artifact-id }}' wait-for-completion: true - output-artifact-directory: 'dist/windows/signed/' + output-artifact-directory: 'dist/' - name: Release uses: softprops/action-gh-release@v2 if: startsWith(github.ref, 'refs/tags/') @@ -64,6 +65,5 @@ jobs: prerelease: true generate_release_notes: true files: | - CHANGELOG.md LICENSE.txt - dist/windows/signed/*.exe + dist/*.exe