fix: keep packaged dialogs inside mobile safe areas

test/e2e-obsidian/runner/session.ts

@@ -8,6 +8,7 @@ export type StartObsidianLiveSyncSessionOptions = {
     cliBinary: string;
     vault: TemporaryVault;
     startupGraceMs?: number;
+    pluginData?: Record<string, unknown>;
 };
 
 export async function startObsidianLiveSyncSession(
@@ -20,5 +21,6 @@ export async function startObsidianLiveSyncSession(
         pluginId: "obsidian-livesync",
         artifactRoot: process.cwd(),
         startupGraceMs: options.startupGraceMs,
+        pluginData: options.pluginData,
     });
 }

test/e2e-obsidian/runner/ui.ts

@@ -1,4 +1,7 @@
+import { mkdir } from "node:fs/promises";
+import { dirname, join } from "node:path";
 import { withObsidianPage } from "@vrtmrz/obsidian-test-session";
+import type { Page } from "playwright";
 
 export {
     obsidianRemoteDebuggingPort,
@@ -7,6 +10,41 @@ export {
     withObsidianPage,
 } from "@vrtmrz/obsidian-test-session";
 
+export async function captureObsidianDialogue(
+    port: number,
+    filename: string,
+    assertReady: (page: Page) => Promise<void>
+): Promise<string> {
+    const outputDirectory = process.env.E2E_OBSIDIAN_DIAGNOSTICS_DIR ?? "/tmp/obsidian-livesync-e2e";
+    const screenshotPath = join(outputDirectory, filename);
+    await mkdir(dirname(screenshotPath), { recursive: true });
+
+    await withObsidianPage(port, async (page) => {
+        try {
+            await assertReady(page);
+        } catch (error) {
+            const failurePath = screenshotPath.replace(/\.png$/u, ".failure.png");
+            await page.screenshot({ path: failurePath, fullPage: true });
+            console.error(`Dialogue failure screenshot: ${failurePath}`);
+            throw error;
+        }
+        await page.screenshot({ path: screenshotPath, fullPage: true });
+    });
+
+    return screenshotPath;
+}
+
+export async function captureJsonResolveDialogue(port: number): Promise<string> {
+    return await captureObsidianDialogue(port, "hidden-file-json-resolve-dialogue.png", async (page) => {
+        const optionAB = page.locator('label:has(input[name="disp"][value="AB"])');
+        const optionBA = page.locator('label:has(input[name="disp"][value="BA"])');
+        const applyButton = page.getByRole("button", { name: "Apply" });
+        await optionAB.waitFor({ state: "visible", timeout: 10000 });
+        await optionBA.waitFor({ state: "visible", timeout: 10000 });
+        await applyButton.waitFor({ state: "visible", timeout: 10000 });
+    });
+}
+
 export async function clickJsonResolveOption(port: number, mode: "AB" | "BA"): Promise<void> {
     await withObsidianPage(port, async (page) => {
         const option = page.locator(`label:has(input[name="disp"][value="${mode}"])`);