fix(setup-wizard): address review — icon, CSS scope, E2E coverage

- Use a plain emoji glyph for the password visibility toggle instead
  of embedded SVG paths, matching the same pragmatic approach already
  used for the browser build's menu icons in this codebase.
- Scope the wider label width to the E2EE dialogue instead of
  changing it for every InputRow in every Svelte dialogue.
- Extend the existing CouchDB manual setup E2E workflow to assert the
  passphrase and Obfuscate Properties fields are hidden until
  encryption is enabled, then appear, and that the passphrase value
  survives toggling its visibility.
This commit is contained in:
Zeedif committed 2026-08-26 20:45:44 -06:00
1 parent 6b37ea8778
commit 2c35f45765
4 files changed
+126 -107

No files matched your search

@@ -110,7 +110,7 @@
.dialog-host :global(label > span) {
display: block;
min-width: 8em;
width: 8em;
}
.dialog-host :global(.note),
@@ -41,37 +41,7 @@
{disabled}
onclick={() => (showPassword = !showPassword)}
>
{#if showPassword}
<svg
viewBox="0 0 24 24"
width="16"
height="16"
fill="none"
stroke="currentColor"
stroke-width="2"
stroke-linecap="round"
stroke-linejoin="round"
>
<path d="M9.88 9.88a3 3 0 1 0 4.24 4.24" />
<path d="M10.73 5.08A10.43 10.43 0 0 1 12 5c7 0 10 7 10 7a13.16 13.16 0 0 1-1.67 2.68" />
<path d="M6.61 6.61A13.526 13.526 0 0 0 2 12s3 7 10 7a9.74 9.74 0 0 0 5.39-1.61" />
<line x1="2" x2="22" y1="2" y2="22" />
</svg>
{:else}
<svg
viewBox="0 0 24 24"
width="16"
height="16"
fill="none"
stroke="currentColor"
stroke-width="2"
stroke-linecap="round"
stroke-linejoin="round"
>
<path d="M2 12s3-7 10-7 10 7 10 7-3 7-10 7-10-7-10-7Z" />
<circle cx="12" cy="12" r="3" />
</svg>
{/if}
👁️
</button>
<style>
@@ -85,11 +55,10 @@
background: transparent;
border: none;
box-shadow: none;
color: var(--text-muted);
line-height: 1;
cursor: pointer;
}
.sls-password-toggle:hover {
color: var(--text-normal);
background: var(--background-modifier-hover);
}
</style>