Reduce deprecated API and dependency warnings

src/modules/essential/ModuleMigration.unit.spec.ts

@@ -18,7 +18,10 @@ async function* failedDocumentScan() {
     throw new Error("scan failed");
 }
 
-function createMigration(findAllNormalDocs: typeof noDocuments | typeof failedDocumentScan = noDocuments) {
+function createMigration(
+    findAllNormalDocs: typeof noDocuments | typeof failedDocumentScan = noDocuments,
+    settings = { sendChunksBulk: false, sendChunksBulkMaxSize: 1 }
+) {
     const noticeGroups = {
         setItem: vi.fn(),
         finish: vi.fn(() => true),
@@ -32,6 +35,7 @@ function createMigration(findAllNormalDocs: typeof noDocuments | typeof failedDo
             registerProtocolHandler: vi.fn(),
         },
         context: { noticeGroups },
+        setting: { saveSettingData: vi.fn(async () => undefined) },
         vault: { isTargetFile: vi.fn(async () => true) },
         path: { getPath: vi.fn() },
     };
@@ -44,13 +48,37 @@ function createMigration(findAllNormalDocs: typeof noDocuments | typeof failedDo
         },
         localDatabase: { findAllNormalDocs },
         storageAccess: {},
+        settings,
     };
     return {
         migration: new ModuleMigration(core as never),
         noticeGroups,
+        saveSettingData: services.setting.saveSettingData,
     };
 }
 
+describe("ModuleMigration obsolete-setting migration", () => {
+    it("persists the removal of an enabled automatic bulk chunk pre-send setting", async () => {
+        const settings = { sendChunksBulk: true, sendChunksBulkMaxSize: 16 };
+        const { migration, saveSettingData } = createMigration(noDocuments, settings);
+
+        await migration.migrateDisableBulkSend();
+
+        expect(settings).toEqual({ sendChunksBulk: false, sendChunksBulkMaxSize: 1 });
+        expect(saveSettingData).toHaveBeenCalledOnce();
+    });
+
+    it("does not persist an already disabled automatic bulk chunk pre-send setting", async () => {
+        const settings = { sendChunksBulk: false, sendChunksBulkMaxSize: 16 };
+        const { migration, saveSettingData } = createMigration(noDocuments, settings);
+
+        await migration.migrateDisableBulkSend();
+
+        expect(settings).toEqual({ sendChunksBulk: false, sendChunksBulkMaxSize: 16 });
+        expect(saveSettingData).not.toHaveBeenCalled();
+    });
+});
+
 describe("ModuleMigration incomplete-document notice", () => {
     it("keeps the check and its result in one persistent named group", async () => {
         const { migration, noticeGroups } = createMigration();