feat: restore opt-in first-run onboarding

src/modules/services/ObsidianSettingService.ts

@@ -1,9 +1,21 @@
 import { compatGlobal } from "@vrtmrz/livesync-commonlib/compat/common/coreEnvFunctions";
 import { type ObsidianLiveSyncSettings } from "@vrtmrz/livesync-commonlib/compat/common/types";
-import { EVENT_REQUEST_RELOAD_SETTING_TAB, EVENT_SETTING_SAVED } from "@vrtmrz/livesync-commonlib/compat/events/coreEvents";
-import { SettingService, type SettingServiceDependencies } from "@vrtmrz/livesync-commonlib/compat/services/base/SettingService";
+import {
+    EVENT_REQUEST_RELOAD_SETTING_TAB,
+    EVENT_SETTING_SAVED,
+} from "@vrtmrz/livesync-commonlib/compat/events/coreEvents";
+import {
+    SettingService,
+    type SettingServiceDependencies,
+} from "@vrtmrz/livesync-commonlib/compat/services/base/SettingService";
 import type { ObsidianServiceContext } from "@/modules/services/ObsidianServiceContext";
 
+export function normaliseObsidianSettingsData(
+    data: ObsidianLiveSyncSettings | null | undefined
+): ObsidianLiveSyncSettings | undefined {
+    return data ?? undefined;
+}
+
 export class ObsidianSettingService<T extends ObsidianServiceContext> extends SettingService<T> {
     constructor(context: T, dependencies: SettingServiceDependencies) {
         super(context, dependencies);
@@ -33,6 +45,6 @@ export class ObsidianSettingService<T extends ObsidianServiceContext> extends Se
         return await this.context.liveSyncPlugin.saveData(data);
     }
     protected override async loadData(): Promise<ObsidianLiveSyncSettings | undefined> {
-        return await this.context.liveSyncPlugin.loadData();
+        return normaliseObsidianSettingsData(await this.context.liveSyncPlugin.loadData());
     }
 }

src/modules/services/ObsidianSettingService.unit.spec.ts

@@ -0,0 +1,15 @@
+import { describe, expect, it } from "vitest";
+import type { ObsidianLiveSyncSettings } from "@vrtmrz/livesync-commonlib/compat/common/types";
+import { normaliseObsidianSettingsData } from "./ObsidianSettingService.ts";
+
+describe("normaliseObsidianSettingsData", () => {
+    it("maps Obsidian's missing data value to Commonlib's new-Vault input", () => {
+        expect(normaliseObsidianSettingsData(null)).toBeUndefined();
+    });
+
+    it("preserves stored settings", () => {
+        const settings = { isConfigured: false } as ObsidianLiveSyncSettings;
+
+        expect(normaliseObsidianSettingsData(settings)).toBe(settings);
+    });
+});