## 0.25.7

### Fixed

- Off-loaded chunking have been fixed to ensure proper functionality (#693).
- Chunk document ID assignment has been fixed.
- Replication prevention message during version up detection has been improved (#686).
- `Keep A` and `Keep B` on Conflict resolving dialogue has been renamed to `Use Base` and `Use Conflicted` (#691).

### Improved

- Metadata and content-size unmatched documents are now detected and reported, prevented to be applied to the storage.

### New Features

- `Scan for Broken files` has been implemented on `Hatch` -> `TroubleShooting`.

### Refactored

- Off-loaded processes have been refactored for the better maintainability.
- Removed unused code.

src/modules/features/SettingDialogue/ObsidianLiveSyncSettingTab.ts

@@ -17,8 +17,6 @@ import { delay, isObjectDifferent, sizeToHumanReadable } from "../../../lib/src/
 import { versionNumberString2Number } from "../../../lib/src/string_and_binary/convert.ts";
 import { Logger } from "../../../lib/src/common/logger.ts";
 import { checkSyncInfo } from "@/lib/src/pouchdb/negotiation.ts";
-import { balanceChunkPurgedDBs } from "@/lib/src/pouchdb/chunks.ts";
-import { purgeUnreferencedChunks } from "@/lib/src/pouchdb/chunks.ts";
 import { testCrypt } from "../../../lib/src/encryption/e2ee_v2.ts";
 import ObsidianLiveSyncPlugin from "../../../main.ts";
 import { scheduleTask } from "../../../common/utils.ts";
@@ -38,7 +36,6 @@ import { LiveSyncSetting as Setting } from "./LiveSyncSetting.ts";
 import { fireAndForget, yieldNextAnimationFrame } from "octagonal-wheels/promises";
 import { confirmWithMessage } from "../../coreObsidian/UILib/dialogs.ts";
 import { EVENT_REQUEST_RELOAD_SETTING_TAB, eventHub } from "../../../common/events.ts";
-import { skipIfDuplicated } from "octagonal-wheels/concurrency/lock";
 import { JournalSyncMinio } from "../../../lib/src/replication/journal/objectstore/JournalSyncMinio.ts";
 import { paneChangeLog } from "./PaneChangeLog.ts";
 import {
@@ -861,49 +858,6 @@ export class ObsidianLiveSyncSettingTab extends PluginSettingTab {
         });
     }
 
-    async dryRunGC() {
-        await skipIfDuplicated("cleanup", async () => {
-            const replicator = this.plugin.$$getReplicator();
-            if (!(replicator instanceof LiveSyncCouchDBReplicator)) return;
-            const remoteDBConn = await replicator.connectRemoteCouchDBWithSetting(
-                this.plugin.settings,
-                this.plugin.$$isMobile()
-            );
-            if (typeof remoteDBConn == "string") {
-                Logger(remoteDBConn);
-                return;
-            }
-            await purgeUnreferencedChunks(remoteDBConn.db, true, this.plugin.settings, false);
-            await purgeUnreferencedChunks(this.plugin.localDatabase.localDatabase, true);
-            this.plugin.localDatabase.clearCaches();
-        });
-    }
-
-    async dbGC() {
-        // Lock the remote completely once.
-        await skipIfDuplicated("cleanup", async () => {
-            const replicator = this.plugin.$$getReplicator();
-            if (!(replicator instanceof LiveSyncCouchDBReplicator)) return;
-            await this.plugin.$$getReplicator().markRemoteLocked(this.plugin.settings, true, true);
-            const remoteDBConnection = await replicator.connectRemoteCouchDBWithSetting(
-                this.plugin.settings,
-                this.plugin.$$isMobile()
-            );
-            if (typeof remoteDBConnection == "string") {
-                Logger(remoteDBConnection);
-                return;
-            }
-            await purgeUnreferencedChunks(remoteDBConnection.db, false, this.plugin.settings, true);
-            await purgeUnreferencedChunks(this.plugin.localDatabase.localDatabase, false);
-            this.plugin.localDatabase.clearCaches();
-            await balanceChunkPurgedDBs(this.plugin.localDatabase.localDatabase, remoteDBConnection.db);
-            this.plugin.localDatabase.refreshSettings();
-            Logger(
-                "The remote database has been cleaned up! Other devices will be cleaned up on the next synchronisation."
-            );
-        });
-    }
-
     getMinioJournalSyncClient() {
         const id = this.plugin.settings.accessKey;
         const key = this.plugin.settings.secretKey;

src/modules/features/SettingDialogue/PaneChangeLog.ts

@@ -3,6 +3,7 @@ import { versionNumberString2Number } from "../../../lib/src/string_and_binary/c
 import { $msg } from "../../../lib/src/common/i18n.ts";
 import { fireAndForget } from "octagonal-wheels/promises";
 import type { ObsidianLiveSyncSettingTab } from "./ObsidianLiveSyncSettingTab.ts";
+import { visibleOnly } from "./SettingPane.ts";
 //@ts-ignore
 const manifestVersion: string = MANIFEST_VERSION || "-";
 //@ts-ignore
@@ -10,8 +11,34 @@ const updateInformation: string = UPDATE_INFO || "";
 
 const lastVersion = ~~(versionNumberString2Number(manifestVersion) / 1000);
 export function paneChangeLog(this: ObsidianLiveSyncSettingTab, paneEl: HTMLElement): void {
-    const informationDivEl = this.createEl(paneEl, "div", { text: "" });
+    const cx = this.createEl(
+        paneEl,
+        "div",
+        {
+            cls: "op-warn-info",
+        },
+        undefined,
+        visibleOnly(() => !this.isConfiguredAs("versionUpFlash", ""))
+    );
 
+    this.createEl(
+        cx,
+        "div",
+        {
+            text: this.editingSettings.versionUpFlash,
+        },
+        undefined
+    );
+    this.createEl(cx, "button", { text: $msg("obsidianLiveSyncSettingTab.btnGotItAndUpdated") }, (e) => {
+        e.addClass("mod-cta");
+        e.addEventListener("click", () => {
+            fireAndForget(async () => {
+                this.editingSettings.versionUpFlash = "";
+                await this.saveAllDirtySettings();
+            });
+        });
+    });
+    const informationDivEl = this.createEl(paneEl, "div", { text: "" });
     const tmpDiv = createDiv();
     // tmpDiv.addClass("sls-header-button");
     tmpDiv.addClass("op-warn-info");

src/modules/features/SettingDialogue/PaneHatch.ts

@@ -26,7 +26,7 @@ import { addPrefix, shouldBeIgnored, stripAllPrefixes } from "../../../lib/src/s
 import { $msg } from "../../../lib/src/common/i18n.ts";
 import { Semaphore } from "octagonal-wheels/concurrency/semaphore";
 import { LiveSyncSetting as Setting } from "./LiveSyncSetting.ts";
-import { EVENT_REQUEST_RUN_DOCTOR, eventHub } from "../../../common/events.ts";
+import { EVENT_REQUEST_RUN_DOCTOR, EVENT_REQUEST_RUN_FIX_INCOMPLETE, eventHub } from "../../../common/events.ts";
 import { ICHeader, ICXHeader, PSCHeader } from "../../../common/types.ts";
 import { HiddenFileSync } from "../../../features/HiddenFileSync/CmdHiddenFileSync.ts";
 import { EVENT_REQUEST_SHOW_HISTORY } from "../../../common/obsidianEvents.ts";
@@ -50,6 +50,19 @@ export function paneHatch(this: ObsidianLiveSyncSettingTab, paneEl: HTMLElement,
                         eventHub.emitEvent(EVENT_REQUEST_RUN_DOCTOR, "you wanted(Thank you)!");
                     })
             );
+        new Setting(paneEl)
+            .setName($msg("Setting.TroubleShooting.ScanBrokenFiles"))
+            .setDesc($msg("Setting.TroubleShooting.ScanBrokenFiles.Desc"))
+            .addButton((button) =>
+                button
+                    .setButtonText("Scan for Broken files")
+                    .setCta()
+                    .setDisabled(false)
+                    .onClick(() => {
+                        this.closeSetting();
+                        eventHub.emitEvent(EVENT_REQUEST_RUN_FIX_INCOMPLETE);
+                    })
+            );
         new Setting(paneEl).setName("Prepare the 'report' to create an issue").addButton((button) =>
             button
                 .setButtonText("Copy Report to clipboard")
@@ -190,7 +203,7 @@ ${stringifyYaml({
                             );
                             infoGroupEl.appendChild(
                                 this.createEl(infoGroupEl, "div", {
-                                    text: `Database: Modified: ${!fileOnDB ? `Missing:` : `${new Date(fileOnDB.mtime).toLocaleString()}, Size:${fileOnDB.size}`}`,
+                                    text: `Database: Modified: ${!fileOnDB ? `Missing:` : `${new Date(fileOnDB.mtime).toLocaleString()}, Size:${fileOnDB.size} (actual size:${readAsBlob(fileOnDB).size})`}`,
                                 })
                             );
                         })

src/modules/features/SettingDialogue/PanePatches.ts

@@ -82,6 +82,7 @@ export function panePatches(this: ObsidianLiveSyncSettingTab, paneEl: HTMLElemen
     void addPanel(paneEl, "Edge case addressing (Behaviour)").then((paneEl) => {
         new Setting(paneEl).autoWireToggle("doNotSuspendOnFetching");
         new Setting(paneEl).setClass("wizardHidden").autoWireToggle("doNotDeleteFolder");
+        new Setting(paneEl).autoWireToggle("processSizeMismatchedFiles");
     });
 
     void addPanel(paneEl, "Edge case addressing (Processing)").then((paneEl) => {

src/modules/features/SettingDialogue/PaneSyncSettings.ts

@@ -7,7 +7,6 @@ import {
 import { Logger } from "../../../lib/src/common/logger.ts";
 import { $msg } from "../../../lib/src/common/i18n.ts";
 import { LiveSyncSetting as Setting } from "./LiveSyncSetting.ts";
-import { fireAndForget } from "octagonal-wheels/promises";
 import { EVENT_REQUEST_COPY_SETUP_URI, eventHub } from "../../../common/events.ts";
 import type { ObsidianLiveSyncSettingTab } from "./ObsidianLiveSyncSettingTab.ts";
 import type { PageFunctions } from "./SettingPane.ts";
@@ -17,30 +16,6 @@ export function paneSyncSettings(
     paneEl: HTMLElement,
     { addPanel, addPane }: PageFunctions
 ): void {
-    if (this.editingSettings.versionUpFlash != "") {
-        const c = this.createEl(
-            paneEl,
-            "div",
-            {
-                text: this.editingSettings.versionUpFlash,
-                cls: "op-warn sls-setting-hidden",
-            },
-            (el) => {
-                this.createEl(el, "button", { text: $msg("obsidianLiveSyncSettingTab.btnGotItAndUpdated") }, (e) => {
-                    e.addClass("mod-cta");
-                    e.addEventListener("click", () => {
-                        fireAndForget(async () => {
-                            this.editingSettings.versionUpFlash = "";
-                            await this.saveAllDirtySettings();
-                            c.remove();
-                        });
-                    });
-                });
-            },
-            visibleOnly(() => !this.isConfiguredAs("versionUpFlash", ""))
-        );
-    }
-
     this.createEl(paneEl, "div", {
         text: $msg("obsidianLiveSyncSettingTab.msgSelectAndApplyPreset"),
         cls: "wizardOnly",