public/obsidian-livesync
1
0
Fork 0
mirror of https://github.com/vrtmrz/obsidian-livesync.git synced 2026-08-27 05:47:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Align host settings with the 1.0 lifecycle

Browse Source
This commit is contained in:
vorotamoroz
2026-07-20 13:20:48 +00:00
parent 52e7bd25da
commit 80d1416a81
28 changed files with 360 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/features/LocalDatabaseMainte/CmdLocalDatabaseMainte.unit.spec.ts
+28 -7
View File
@@ -3,8 +3,12 @@ import { DEFAULT_SETTINGS } from "@vrtmrz/livesync-commonlib/compat/common/types
import { ensureLocalDatabaseMaintenancePrerequisites } from "./maintenancePrerequisites";
function createPrerequisites(settingsOverride: Partial<typeof DEFAULT_SETTINGS> = {}) {
const askSelectStringDialogue = vi.fn<() => Promise<"Apply and continue" | "Cancel" | false | undefined>>(
async () => "Apply and continue"
const askSelectStringDialogue = vi.fn(
async (
_message: string,
_buttons: readonly ["Apply and continue", "Cancel"],
_options: { title: string; defaultAction: "Cancel" }
): Promise<"Apply and continue" | "Cancel" | false | undefined> => "Apply and continue"
);
const applyPartial = vi.fn(async () => undefined);
const settings = {
@@ -18,13 +22,12 @@ function createPrerequisites(settingsOverride: Partial<typeof DEFAULT_SETTINGS>
}
describe("LocalDatabaseMaintenance prerequisites", () => {
it("asks to apply missing prerequisite settings before maintenance actions", async () => {
it("asks to disable on-demand chunk fetching before maintenance actions", async () => {
const { settings, askSelectStringDialogue, applyPartial } = createPrerequisites();
const result = await ensureLocalDatabaseMaintenancePrerequisites({
operationName: "Garbage Collection",
settings: {
doNotUseFixedRevisionForChunks: settings.doNotUseFixedRevisionForChunks,
readChunksOnline: settings.readChunksOnline,
},
askSelectStringDialogue,
@@ -42,11 +45,11 @@ describe("LocalDatabaseMaintenance prerequisites", () => {
);
expect(applyPartial).toHaveBeenCalledWith(
{
doNotUseFixedRevisionForChunks: true,
readChunksOnline: false,
},
true
);
expect(vi.mocked(askSelectStringDialogue).mock.calls[0]?.[0]).not.toContain("Compute revisions for chunks");
});
it("cancels maintenance actions when prerequisite changes are rejected", async () => {
@@ -56,7 +59,6 @@ describe("LocalDatabaseMaintenance prerequisites", () => {
const result = await ensureLocalDatabaseMaintenancePrerequisites({
operationName: "Garbage Collection",
settings: {
doNotUseFixedRevisionForChunks: settings.doNotUseFixedRevisionForChunks,
readChunksOnline: settings.readChunksOnline,
},
askSelectStringDialogue,
@@ -76,7 +78,6 @@ describe("LocalDatabaseMaintenance prerequisites", () => {
const result = await ensureLocalDatabaseMaintenancePrerequisites({
operationName: "Garbage Collection",
settings: {
doNotUseFixedRevisionForChunks: settings.doNotUseFixedRevisionForChunks,
readChunksOnline: settings.readChunksOnline,
},
askSelectStringDialogue,
@@ -86,4 +87,24 @@ describe("LocalDatabaseMaintenance prerequisites", () => {
expect(askSelectStringDialogue).not.toHaveBeenCalled();
expect(applyPartial).not.toHaveBeenCalled();
});
it("does not treat the obsolete fixed-revision key as a maintenance prerequisite", async () => {
const { settings, askSelectStringDialogue, applyPartial } = createPrerequisites({
doNotUseFixedRevisionForChunks: false,
readChunksOnline: false,
});
const result = await ensureLocalDatabaseMaintenancePrerequisites({
operationName: "Garbage Collection",
settings: {
readChunksOnline: settings.readChunksOnline,
},
askSelectStringDialogue,
applyPartial,
});
expect(result).toBe(true);
expect(askSelectStringDialogue).not.toHaveBeenCalled();
expect(applyPartial).not.toHaveBeenCalled();
});
});