Preserve Fast Setup choices while translating at display time

This commit is contained in:
vorotamoroz committed 2026-10-13 11:04:09 +00:00
1 parent d346bb27ab
commit 8c258c9224
4 files changed
+178 -31

No files matched your search

@@ -0,0 +1,116 @@
import { afterEach, describe, expect, it, vi } from "vitest";
import type { NecessaryServices } from "@vrtmrz/livesync-commonlib/compat/interfaces/ServiceModule";
import { FullScanModes } from "@vrtmrz/livesync-commonlib/compat/serviceFeatures/offlineScanner";
import { $msg, setLang } from "@/common/translation";
import { askSimpleFetchMode } from "./redFlag.simpleFetch";
const REMOTE_WINS = "Overwrite all with remote files";
const KEEP_LOCAL = "Keep local files even if not on remote";
function createHost(savedChoice?: string) {
const smallConfig = new Map<string, string>();
if (savedChoice) smallConfig.set("simple-fetch-mode", savedChoice);
const confirmWithMessage =
vi.fn<(title: string, message: string, buttons: string[], defaultAction: string) => Promise<string | false>>();
const host = {
services: {
UI: { confirm: { confirmWithMessage } },
setting: {
getSmallConfig: (key: string) => smallConfig.get(key) ?? "",
setSmallConfig: (key: string, value: string) => smallConfig.set(key, value),
deleteSmallConfig: (key: string) => smallConfig.delete(key),
},
},
} as unknown as NecessaryServices<"UI" | "setting", never>;
return { host, confirmWithMessage, smallConfig };
}
afterEach(() => setLang("def"));
describe("Fast Setup translated choices", () => {
it("uses the current language after the module has loaded and saves stable choice values", async () => {
const { host, confirmWithMessage, smallConfig } = createHost();
setLang("es");
confirmWithMessage.mockImplementation(async (_title, _message, buttons) => buttons[1]);
await expect(askSimpleFetchMode(host)).resolves.toEqual({
mode: "remote-only",
options: { mode: FullScanModes.DB_APPLY, extraOnRemote: undefined },
});
const [title, message, buttons] = confirmWithMessage.mock.calls[0];
expect(title).toBe($msg("Data retrieval scheduled"));
expect(buttons[1]).toBe($msg(REMOTE_WINS));
expect(buttons[1]).not.toBe(REMOTE_WINS);
expect(message).toContain($msg(REMOTE_WINS));
expect(confirmWithMessage.mock.calls[1][2][1]).toBe($msg(KEEP_LOCAL));
expect(JSON.parse(smallConfig.get("simple-fetch-mode")!)).toEqual({
stage1: REMOTE_WINS,
stage2: KEEP_LOCAL,
});
});
it("restores choices saved by the previous English implementation while displaying Spanish", async () => {
const savedChoice = JSON.stringify({ stage1: REMOTE_WINS, stage2: KEEP_LOCAL });
const { host, confirmWithMessage, smallConfig } = createHost(savedChoice);
setLang("es");
await expect(askSimpleFetchMode(host)).resolves.toEqual({
mode: "remote-only",
options: { mode: FullScanModes.DB_APPLY, extraOnRemote: undefined },
});
expect(confirmWithMessage).not.toHaveBeenCalled();
expect(smallConfig.get("simple-fetch-mode")).toBe(savedChoice);
});
it("uses the new language in the second dialogue without changing the first choice", async () => {
const { host, confirmWithMessage, smallConfig } = createHost();
setLang("def");
confirmWithMessage
.mockImplementationOnce(async (_title, _message, buttons) => {
setLang("es");
return buttons[1];
})
.mockImplementationOnce(async (_title, _message, buttons) => buttons[1]);
await expect(askSimpleFetchMode(host)).resolves.toMatchObject({ mode: "remote-only" });
expect(confirmWithMessage.mock.calls[0][2][1]).toBe(REMOTE_WINS);
expect(confirmWithMessage.mock.calls[1][2][1]).toBe($msg(KEEP_LOCAL));
expect(JSON.parse(smallConfig.get("simple-fetch-mode")!)).toEqual({
stage1: REMOTE_WINS,
stage2: KEEP_LOCAL,
});
});
it("recognises the translated cancellation choice", async () => {
const { host, confirmWithMessage, smallConfig } = createHost();
setLang("es");
confirmWithMessage.mockImplementationOnce(async (_title, _message, buttons) => buttons[3]);
await expect(askSimpleFetchMode(host)).resolves.toBe("cancelled");
expect(confirmWithMessage.mock.calls[0][2][3]).toBe($msg("Cancel"));
expect(smallConfig.size).toBe(0);
});
it("saves English-compatible values when the module initially loads in Spanish", async () => {
vi.resetModules();
const translation = await import("@/common/translation");
translation.setLang("es");
const { askSimpleFetchMode: askAfterSpanishStartup } = await import("./redFlag.simpleFetch");
const { host, confirmWithMessage, smallConfig } = createHost();
confirmWithMessage.mockImplementation(async (_title, _message, buttons) => buttons[1]);
try {
await expect(askAfterSpanishStartup(host)).resolves.toMatchObject({ mode: "remote-only" });
expect(JSON.parse(smallConfig.get("simple-fetch-mode")!)).toEqual({
stage1: REMOTE_WINS,
stage2: KEEP_LOCAL,
});
} finally {
translation.setLang("def");
}
});
});