fix: align chunk reads with remote delivery

Consume commonlib's delivery lifecycle, classify finite replication entry points, and document why the five-minute inactivity fuse is only a leak safety valve. Record the remote-activity counter correction and preserve continuous replication's unbounded live channel.

src/modules/core/ModuleReplicator.ts

@@ -150,7 +150,11 @@ Even if you choose to clean up, you will see this option again if you exit Obsid
                         await purgeUnreferencedChunks(this.localDatabase.localDatabase, false);
                         this.localDatabase.clearCaches();
                         // Perform the synchronisation once.
-                        if (await this.core.replicator.openReplication(this.settings, false, showMessage, true)) {
+                        const replicated = await this.services.replicator.runFiniteReplicationActivity(
+                            () => this.core.replicator.openReplication(this.settings, false, showMessage, true),
+                            { label: "replication" }
+                        );
+                        if (replicated) {
                             await balanceChunkPurgedDBs(this.localDatabase.localDatabase, remoteDB.db);
                             await purgeUnreferencedChunks(this.localDatabase.localDatabase, false);
                             this.localDatabase.clearCaches();

src/modules/core/ModuleReplicator.unit.spec.ts

@@ -69,6 +69,7 @@ describe("ModuleReplicator legacy cleanup", () => {
                 activityFinished();
             }
         });
+        const runFiniteReplicationActivity = vi.fn(async (task: () => unknown) => await task());
         const openReplication = vi.fn(async () => true);
         const activeReplicator = Object.assign(new LiveSyncCouchDBReplicator({} as any), {
             connectRemoteCouchDBWithSetting: vi.fn(async () => ({ db: {} })),
@@ -90,6 +91,7 @@ describe("ModuleReplicator legacy cleanup", () => {
             replicator: {
                 getActiveReplicator: vi.fn(() => activeReplicator),
                 runBoundedRemoteActivity,
+                runFiniteReplicationActivity,
             },
         };
         const localDatabase = {
@@ -111,6 +113,9 @@ describe("ModuleReplicator legacy cleanup", () => {
         expect(runBoundedRemoteActivity).toHaveBeenCalledWith(expect.any(Function), {
             label: "database-cleanup",
         });
+        expect(runFiniteReplicationActivity).toHaveBeenCalledWith(expect.any(Function), {
+            label: "replication",
+        });
         expect(openReplication).toHaveBeenCalledOnce();
         expect(openReplication.mock.invocationCallOrder[0]).toBeLessThan(activityFinished.mock.invocationCallOrder[0]);
         expect(chunkMocks.balanceChunkPurgedDBs).toHaveBeenCalledOnce();

src/modules/core/ModuleReplicatorCouchDB.ts

@@ -33,7 +33,7 @@ export class ModuleReplicatorCouchDB extends AbstractModule {
                     if (continuous) {
                         void openReplication();
                     } else {
-                        await this.services.replicator.runBoundedRemoteActivity(openReplication, {
+                        await this.services.replicator.runFiniteReplicationActivity(openReplication, {
                             label: "replication",
                         });
                     }

src/modules/core/ModuleReplicatorCouchDB.unit.spec.ts

@@ -3,7 +3,7 @@ import { ModuleReplicatorCouchDB } from "./ModuleReplicatorCouchDB.ts";
 
 function createModule(settings: { liveSync: boolean; syncOnStart: boolean }, isReplicationReady = true) {
     const openReplication = vi.fn(async () => true);
-    const runBoundedRemoteActivity = vi.fn(async (task: () => unknown) => await task());
+    const runFiniteReplicationActivity = vi.fn(async (task: () => unknown) => await task());
     const services = {
         API: {
             addLog: vi.fn(),
@@ -20,7 +20,7 @@ function createModule(settings: { liveSync: boolean; syncOnStart: boolean }, isR
             isReplicationReady: vi.fn(async () => isReplicationReady),
         },
         replicator: {
-            runBoundedRemoteActivity,
+            runFiniteReplicationActivity,
         },
         setting: {
             saveSettingData: vi.fn(async () => undefined),
@@ -38,13 +38,13 @@ function createModule(settings: { liveSync: boolean; syncOnStart: boolean }, isR
     return {
         module: new ModuleReplicatorCouchDB(core),
         openReplication,
-        runBoundedRemoteActivity,
+        runFiniteReplicationActivity,
     };
 }
 
 describe("ModuleReplicatorCouchDB resume replication activity", () => {
-    it("runs start-up one-shot replication through bounded remote activity", async () => {
-        const { module, openReplication, runBoundedRemoteActivity } = createModule({
+    it("exposes start-up one-shot replication as finite replication activity", async () => {
+        const { module, openReplication, runFiniteReplicationActivity } = createModule({
             liveSync: false,
             syncOnStart: true,
         });
@@ -52,14 +52,14 @@ describe("ModuleReplicatorCouchDB resume replication activity", () => {
         await module._everyAfterResumeProcess();
 
         await vi.waitFor(() => expect(openReplication).toHaveBeenCalledOnce());
-        expect(runBoundedRemoteActivity).toHaveBeenCalledWith(expect.any(Function), {
+        expect(runFiniteReplicationActivity).toHaveBeenCalledWith(expect.any(Function), {
             label: "replication",
         });
         expect(openReplication).toHaveBeenCalledWith(expect.any(Object), false, false, false);
     });
 
-    it("does not treat continuous replication as bounded activity", async () => {
-        const { module, openReplication, runBoundedRemoteActivity } = createModule({
+    it("does not wrap the unbounded continuous channel in another finite activity", async () => {
+        const { module, openReplication, runFiniteReplicationActivity } = createModule({
             liveSync: true,
             syncOnStart: false,
         });
@@ -67,12 +67,12 @@ describe("ModuleReplicatorCouchDB resume replication activity", () => {
         await module._everyAfterResumeProcess();
 
         await vi.waitFor(() => expect(openReplication).toHaveBeenCalledOnce());
-        expect(runBoundedRemoteActivity).not.toHaveBeenCalled();
+        expect(runFiniteReplicationActivity).not.toHaveBeenCalled();
         expect(openReplication).toHaveBeenCalledWith(expect.any(Object), true, false, false);
     });
 
     it("does not start a one-shot activity when start-up readiness fails", async () => {
-        const { module, openReplication, runBoundedRemoteActivity } = createModule(
+        const { module, openReplication, runFiniteReplicationActivity } = createModule(
             {
                 liveSync: false,
                 syncOnStart: true,
@@ -83,7 +83,7 @@ describe("ModuleReplicatorCouchDB resume replication activity", () => {
         await module._everyAfterResumeProcess();
         await new Promise((resolve) => setTimeout(resolve, 0));
 
-        expect(runBoundedRemoteActivity).not.toHaveBeenCalled();
+        expect(runFiniteReplicationActivity).not.toHaveBeenCalled();
         expect(openReplication).not.toHaveBeenCalled();
     });
 });