feat(syncguard): model bounded catch-up editing guard

This commit is contained in:
Artem Ovchinnikov committed 2026-10-21 20:58:39 +03:00
1 parent ce0524d49f
commit c7d59c78d9
2 files changed
+208

No files matched your search

@@ -0,0 +1,91 @@
import { describe, expect, it, vi } from "vitest";
import { SyncGuardState, type SyncGuardPresentation } from "./SyncGuardState";
describe("SyncGuardState", () => {
function setup() {
const presentations: SyncGuardPresentation[] = [];
const onChange = vi.fn((value: SyncGuardPresentation) => presentations.push(value));
const guard = new SyncGuardState(onChange, 2000);
return { guard, onChange, presentations };
}
it("never locks for a small incoming change batch", () => {
const { guard } = setup();
guard.resume(true, 20);
guard.finiteActivityChanged(true, 0, 0);
guard.receivedDocuments(["f:one", "f:two"]);
guard.replicationStatusChanged("COMPLETED");
guard.finiteActivityChanged(false, 0, 10);
expect(guard.presentation.phase).toBe("idle");
});
it("counts distinct Metadata rather than repeated changes and waits for local application", () => {
const { guard } = setup();
guard.resume(true, 3);
guard.finiteActivityChanged(true, 0, 0);
guard.receivedDocuments(["f:one", "f:one", "f:two"]);
expect(guard.presentation.phase).toBe("observing");
guard.receivedDocuments(["f:three"]);
expect(guard.presentation).toEqual({ phase: "transferring", receivedFiles: 3 });
guard.replicationStatusChanged("COMPLETED");
guard.finiteActivityChanged(false, 2, 10);
expect(guard.presentation.phase).toBe("applying");
guard.tick(0, 20);
guard.tick(1, 2000);
guard.tick(0, 2100);
guard.tick(0, 4099);
expect(guard.presentation.phase).toBe("applying");
guard.tick(0, 4100);
expect(guard.presentation.phase).toBe("idle");
});
it("keeps the lock with an interrupted transfer until the user bypasses it", () => {
const { guard } = setup();
guard.resume(true, 2);
guard.finiteActivityChanged(true, 0, 0);
guard.receivedDocuments(["f:one", "f:two"]);
guard.replicationStatusChanged("ERRORED");
guard.finiteActivityChanged(false, 0, 10);
expect(guard.presentation.phase).toBe("interrupted");
guard.bypass();
expect(guard.presentation.phase).toBe("idle");
guard.receivedDocuments(["f:other"]);
expect(guard.presentation.phase).toBe("idle");
});
it("does not confuse a stale completed status with this catch-up", () => {
const { guard } = setup();
guard.resume(true, 1);
guard.replicationStatusChanged("COMPLETED");
guard.finiteActivityChanged(true, 0, 0);
guard.receivedDocuments(["f:one"]);
guard.finiteActivityChanged(false, 0, 1);
expect(guard.presentation.phase).toBe("interrupted");
});
it("resets after resume and is opt-in", () => {
const { guard } = setup();
guard.resume(false, 1);
guard.finiteActivityChanged(true, 0, 0);
guard.receivedDocuments(["f:one"]);
expect(guard.presentation.phase).toBe("idle");
guard.resume(true, 1);
guard.finiteActivityChanged(true, 0, 10);
guard.receivedDocuments(["f:one"]);
expect(guard.presentation.phase).toBe("transferring");
guard.disable();
expect(guard.presentation.phase).toBe("idle");
});
it("handles NaN and negative thresholds conservatively", () => {
const { guard } = setup();
guard.resume(true, NaN);
guard.finiteActivityChanged(true, 0, 0);
guard.receivedDocuments(["f:one"]);
expect(guard.presentation.phase).toBe("observing");
guard.resume(true, -2);
guard.finiteActivityChanged(true, 0, 10);
guard.receivedDocuments(["f:one"]);
expect(guard.presentation.phase).toBe("transferring");
});
});