Restore Sync now progress and recovery policy

src/modules/essential/ModuleBasicMenu.ts

@@ -4,7 +4,10 @@ import { fireAndForget } from "octagonal-wheels/promises";
 import { AbstractModule } from "@/modules/AbstractModule";
 import { $msg } from "@/common/translation";
 import { copyFileDatabaseInfo } from "@/serviceFeatures/fileDatabaseInfo";
-import { USER_INITIATED_REPLICATION_AUTHORITY } from "@vrtmrz/livesync-commonlib/replication";
+import {
+    REPLICATION_PROGRESS_PRESENTATIONS,
+    USER_INITIATED_REPLICATION_AUTHORITY,
+} from "@vrtmrz/livesync-commonlib/replication";
 // Separated Module for basic menu commands, which are not related to obsidian specific features. It is expected to be used in other platforms with minimal changes.
 // However, it is odd that it has here at all; it really ought to be in each respective feature. It will likely be moved eventually. Until now, addCommand pointed to Obsidian's version.
 export class ModuleBasicMenu extends AbstractModule {
@@ -15,6 +18,7 @@ export class ModuleBasicMenu extends AbstractModule {
             callback: async () => {
                 await this.services.replication.replicateUserInitiated({
                     trigger: "manual",
+                    progressPresentation: REPLICATION_PROGRESS_PRESENTATIONS.QUIET,
                     interaction: USER_INITIATED_REPLICATION_AUTHORITY,
                 });
             },

src/modules/essential/ModuleBasicMenu.unit.spec.ts

@@ -1,5 +1,9 @@
 import { describe, expect, it, vi } from "vitest";
 import type { Command } from "@/deps";
+import {
+    REPLICATION_PROGRESS_PRESENTATIONS,
+    USER_INITIATED_REPLICATION_AUTHORITY,
+} from "@vrtmrz/livesync-commonlib/replication";
 import { ModuleBasicMenu } from "./ModuleBasicMenu";
 
 type RegisteredCommand = Command & {
@@ -124,6 +128,19 @@ describe("ModuleBasicMenu command palette", () => {
         expect(fixture.getCommand("livesync-runbatch").name).toBe("Apply pending changes now");
     });
 
+    it("keeps Sync now progress quiet while retaining failure-recovery authority", async () => {
+        const fixture = createFixture();
+
+        await fixture.module._everyOnloadStart();
+        await fixture.getCommand("livesync-replicate").callback?.();
+
+        expect(fixture.services.replication.replicateUserInitiated).toHaveBeenCalledWith({
+            trigger: "manual",
+            progressPresentation: REPLICATION_PROGRESS_PRESENTATIONS.QUIET,
+            interaction: USER_INITIATED_REPLICATION_AUTHORITY,
+        });
+    });
+
     it("keeps maintenance commands out of the normal palette", async () => {
         const fixture = createFixture();
 

src/modules/essentialObsidian/ModuleObsidianMenu.ts

@@ -2,7 +2,10 @@ import { addIcon } from "@/deps.ts";
 import { $msg } from "@/common/translation";
 import type { LiveSyncCore } from "@/main.ts";
 import { AbstractModule } from "@/modules/AbstractModule.ts";
-import { USER_INITIATED_REPLICATION_AUTHORITY } from "@vrtmrz/livesync-commonlib/replication";
+import {
+    REPLICATION_PROGRESS_PRESENTATIONS,
+    USER_INITIATED_REPLICATION_AUTHORITY,
+} from "@vrtmrz/livesync-commonlib/replication";
 // Obsidian specific menu commands.
 export class ModuleObsidianMenu extends AbstractModule {
     _everyOnloadStart(): Promise<boolean> {
@@ -20,6 +23,7 @@ export class ModuleObsidianMenu extends AbstractModule {
         this.addRibbonIcon("replicate", $msg("moduleObsidianMenu.replicate"), async () => {
             await this.services.replication.replicateUserInitiated({
                 trigger: "manual",
+                progressPresentation: REPLICATION_PROGRESS_PRESENTATIONS.NOTICE,
                 interaction: USER_INITIATED_REPLICATION_AUTHORITY,
             });
         }).addClass("livesync-ribbon-replicate");

src/modules/essentialObsidian/ModuleObsidianMenu.unit.spec.ts

@@ -0,0 +1,41 @@
+import { describe, expect, it, vi } from "vitest";
+
+vi.mock("@/deps.ts", () => ({ addIcon: vi.fn() }));
+
+import {
+    REPLICATION_PROGRESS_PRESENTATIONS,
+    USER_INITIATED_REPLICATION_AUTHORITY,
+} from "@vrtmrz/livesync-commonlib/replication";
+import { ModuleObsidianMenu } from "./ModuleObsidianMenu";
+
+describe("ModuleObsidianMenu ribbon", () => {
+    it("retains visible progress and full interaction authority", async () => {
+        let runRibbonAction: (() => Promise<void>) | undefined;
+        const addClass = vi.fn();
+        const replicateUserInitiated = vi.fn(async () => ({ status: "completed" as const }));
+        const services = {
+            API: {
+                addLog: vi.fn(),
+                addCommand: vi.fn(),
+                registerWindow: vi.fn(),
+                registerProtocolHandler: vi.fn(),
+                addRibbonIcon: vi.fn((_icon: string, _title: string, callback: () => Promise<void>) => {
+                    runRibbonAction = callback;
+                    return { addClass };
+                }),
+            },
+            replication: { replicateUserInitiated },
+        };
+        const module = new ModuleObsidianMenu({ _services: services, services } as never);
+
+        await module._everyOnloadStart();
+        await runRibbonAction?.();
+
+        expect(replicateUserInitiated).toHaveBeenCalledWith({
+            trigger: "manual",
+            progressPresentation: REPLICATION_PROGRESS_PRESENTATIONS.NOTICE,
+            interaction: USER_INITIATED_REPLICATION_AUTHORITY,
+        });
+        expect(addClass).toHaveBeenCalledWith("livesync-ribbon-replicate");
+    });
+});