public/tt-rss
1
0
Fork 0
mirror of https://git.tt-rss.org/git/tt-rss.git synced 2025-12-13 14:35:55 +00:00
Code Issues Releases Wiki Activity

update phpmd ruleset to use (subset) of cleancode

Browse Source 
fix various minor issues reported by static analysis
remove redundant php closing tag from several more files
This commit is contained in:
Andrew Dolgov
2017-04-26 20:57:36 +03:00
parent ea79a0e033
commit 21ce7d9ec0
53 changed files with 138 additions and 173 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
plugins/cache_starred_images/init.php
View File

@@ -11,10 +11,16 @@ class Cache_Starred_Images extends Plugin implements IHandler {
true);
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
function csrf_ignore($method) {
return false;
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
function before($method) {
return true;
}
@@ -88,6 +94,9 @@ class Cache_Starred_Images extends Plugin implements IHandler {
}
}
/**
* @SuppressWarnings(PHPMD.UnusedLocalVariable)
*/
function hook_house_keeping() {
$files = glob($this->cache_dir . "/*.{png,mp4}", GLOB_BRACE);
@@ -112,6 +121,9 @@ class Cache_Starred_Images extends Plugin implements IHandler {
}
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
function hook_sanitize($doc, $site_url, $allowed_elements, $disallowed_attributes, $article_id) {
$xpath = new DOMXpath($doc);
@@ -162,6 +174,9 @@ class Cache_Starred_Images extends Plugin implements IHandler {
}
}
/**
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
*/
function cache_article_images($content, $site_url, $owner_uid, $article_id) {
libxml_use_internal_errors(true);
@@ -211,4 +226,3 @@ class Cache_Starred_Images extends Plugin implements IHandler {
return 2;
}
}
?>