public/tt-rss
1
0
Fork 0
mirror of https://git.tt-rss.org/git/tt-rss.git synced 2025-12-24 13:31:28 +00:00
Code Issues Releases Wiki Activity

Consistently handle param string to bool conversions in handlers.

Browse Source
This commit is contained in:
wn_
2021-11-18 18:07:43 +00:00
parent d6f604c06c
commit 2422aae577
6 changed files with 31 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
classes/pref/feeds.php
View File

@@ -47,7 +47,7 @@ class Pref_Feeds extends Handler_Protected {
$search = "";
// first one is set by API
$show_empty_cats = clean($_REQUEST['force_show_empty'] ?? false) ||
$show_empty_cats = self::_param_to_bool($_REQUEST['force_show_empty'] ?? null) ||
(clean($_REQUEST['mode'] ?? 0) != 2 && !$search);
$items = [];
@@ -208,7 +208,7 @@ class Pref_Feeds extends Handler_Protected {
}
if ($enable_cats) {
$show_empty_cats = clean($_REQUEST['force_show_empty'] ?? false) ||
$show_empty_cats = self::_param_to_bool($_REQUEST['force_show_empty'] ?? null) ||
(clean($_REQUEST['mode'] ?? 0) != 2 && !$search);
$feed_categories = ORM::for_table('ttrss_feed_categories')
@@ -1260,7 +1260,7 @@ class Pref_Feeds extends Handler_Protected {
function regenFeedKey(): void {
$feed_id = clean($_REQUEST['id']);
$is_cat = clean($_REQUEST['is_cat']);
$is_cat = self::_param_to_bool($_REQUEST['is_cat'] ?? null);
$new_key = Feeds::_update_access_key($feed_id, $is_cat, $_SESSION["uid"]);
@@ -1269,7 +1269,7 @@ class Pref_Feeds extends Handler_Protected {
function getSharedURL(): void {
$feed_id = clean($_REQUEST['id']);
$is_cat = clean($_REQUEST['is_cat']) == "true";
$is_cat = self::_param_to_bool($_REQUEST['is_cat'] ?? null);
$search = clean($_REQUEST['search']);
$link = Config::get_self_url() . "/public.php?" . http_build_query([