mirror of
https://github.com/seejohnrun/haste-client.git
synced 2026-01-09 19:59:16 +00:00
Add pull request template
This commit is contained in:
32
.github/pull_request_template.md
vendored
Normal file
32
.github/pull_request_template.md
vendored
Normal file
@@ -0,0 +1,32 @@
|
||||
[ABC-1234](https://toptal-core.atlassian.net/browse/ABC-1234)
|
||||
|
||||
### Description
|
||||
|
||||
Describe the changes and motivations for the pull request, unless obvious from the title.
|
||||
|
||||
[Designs](https://share.abstract.com) (if applicable)
|
||||
|
||||
### How to test
|
||||
|
||||
- `yarn`
|
||||
- FIXME: Add the steps describing how to test your changes manually
|
||||
|
||||
### Environment variables
|
||||
|
||||
Include a snapshot of the ENV vars used in your local env when this PR was created.
|
||||
```
|
||||
PUBLIC_ENV_VAR=public-value
|
||||
GLOBAL_SECRET_ENV_VAR=xxx # Added in 1Password in Shared-Utilities-Environment group
|
||||
OWN_PRIVATE_ENV_VAR # Different for everyone
|
||||
```
|
||||
|
||||
### Acceptance Criteria
|
||||
|
||||
- [ ] Add acceptance criterias from Jira task [ABC-1234]
|
||||
|
||||
### Pre-merge checklist
|
||||
|
||||
- [ ] The PR relates to a single subject with a clear title and description in grammatically correct, complete sentences.
|
||||
- [ ] Verify that feature branch is up-to-date with `master` (if not - rebase it).
|
||||
- [ ] Double check the quality of [commit messages](http://chris.beams.io/posts/git-commit/).
|
||||
- [ ] A snapshot of the author's env vars has been added
|
||||
Reference in New Issue
Block a user