1
0
mirror of https://github.com/seejohnrun/haste-client.git synced 2025-12-25 04:51:29 +00:00
Files
haste-client/.github/pull_request_template.md
2023-01-16 14:37:34 +01:00

34 lines
1.0 KiB
Markdown

[ABC-1234](https://toptal-core.atlassian.net/browse/ABC-1234)
### Description
Describe the changes and motivations for the pull request, unless obvious from the title.
[Designs](https://share.abstract.com) (if applicable)
### How to test
- `bundle install`
- FIXME: Add the steps describing how to test your changes manually
### Environment variables
Include a snapshot of the ENV vars used in your local env when this PR was created.
```
PUBLIC_ENV_VAR=public-value
GLOBAL_SECRET_ENV_VAR=xxx # Added in 1Password in Shared-Utilities-Environment group
OWN_PRIVATE_ENV_VAR # Different for everyone
```
### Acceptance Criteria
- [ ] Add acceptance criterias from Jira task [ABC-1234]
### Pre-merge checklist
- [ ] The PR relates to a single subject with a clear title and description in grammatically correct, complete sentences.
- [ ] Verify that feature branch is up-to-date with `master` (if not - rebase it).
- [ ] Double check the quality of [commit messages](http://chris.beams.io/posts/git-commit/).
- [ ] A snapshot of the author's env vars has been added